-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Auth/PM-3833 - Remove Deprecated Register and Prelogin endpoints from API #4206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JaredSnider-Bitwarden
merged 6 commits into
main
from
auth/pm-3833/remove-register-and-prelogin-from-api
Jun 19, 2024
Merged
Auth/PM-3833 - Remove Deprecated Register and Prelogin endpoints from API #4206
JaredSnider-Bitwarden
merged 6 commits into
main
from
auth/pm-3833/remove-register-and-prelogin-from-api
Jun 19, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve prelogin and register endpoints.
…n and PostRegister from API to Identity.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4206 +/- ##
==========================================
- Coverage 40.68% 40.55% -0.14%
==========================================
Files 1239 1235 -4
Lines 59492 59328 -164
Branches 5434 5423 -11
==========================================
- Hits 24206 24058 -148
+ Misses 34160 34144 -16
Partials 1126 1126 ☔ View full report in Codecov by Sentry. |
…egister-and-prelogin-from-api # Conflicts: # src/Identity/Controllers/AccountsController.cs # test/Identity.IntegrationTest/Controllers/AccountsControllerTests.cs # test/Identity.Test/Controllers/AccountsControllerTests.cs
This comment was marked as off-topic.
This comment was marked as off-topic.
jlf0dev
approved these changes
Jun 19, 2024
doy
added a commit
to doy/rbw
that referenced
this pull request
Jun 26, 2024
the prelogin endpoint on the base api is being removed soon, see bitwarden/server#4206
withinfocus
pushed a commit
that referenced
this pull request
Jul 9, 2024
… API (#4206) * PM-3833 - API - AccountsController.cs && AccountsController.cs - remove prelogin and register endpoints. * PM-3833 - Move Request and Response models that were used for Prelogin and PostRegister from API to Identity. * PM-3833 - FIX LINT * PM-3833 - Fix issues after merge conflict fixes. * PM-3833 - Another test fix
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Apr 26, 2025
[1.13.2] - 2025-01-06
Fixed
Try another clipboard backend to try to fix cross platform issues. (Mag Mell, #226)
rbw unlocked no longer starts the agent if it isn't running. (#223)
The cardholder_name field is now correctly populated for card entries. (#204)
Fix ip address url matching when using the domain match type. (#211)
Make the behavior of matching urls with no paths when using the exact match type more consistent. (#211)
[1.13.1] - 2024-12-27
Fixed
Moved clipboard support to a (default-enabled) feature, since not all platforms support it (disabling this feature should allow Android builds to work again).
[1.13.0] - 2024-12-26
Fixed
Fix preventing the password type selectors in rbw generate from being used together. (antecrescent, #198)
Fix --clipboard on Wayland (Maksim Karelov, #192)
Fix parsing vaults with entries that have non-null field types (Tin Lai, #212)
Fix lock timeout being reset when checking version (aeber, #216)
Update API request headers to pass new stricter validation on the official bitwarden.com server (Davide Laezza, #219)
Make it possible to start the rbw agent process from a graphical session and then access it over SSH (Wim de With, #221)
[1.12.1] - 2024-07-28
Fixed
Fix decrypting folder names of entries with individual item encryption keys.
[1.12.0] - 2024-07-28
NOTE: If you were affected by issue #163 (getting messages like failed to decrypt encrypted secret: invalid mac when doing any operations on your vault), you will need to rbw sync after upgrading in order to update your local vault with the necessary new data.
Fixed
Support decrypting entries encrypted with invididual item encryption keys, which are now generated by default from the official Bitwarden clients. (#163)
Correctly handle lowercased and padded base32 TOTP secrets. (owl, #189)
Make locking agent memory to RAM optional, since it appears to not always be available. (#143)
[1.11.1] - 2024-06-26
Fixed
Updated the prelogin API endpoint to use the identity API instead of the base API, to correspond with upcoming changes to the official Bitwarden server (see bitwarden/server#4206)
[1.11.0] - 2024-06-20
Added
Support SSO login. (dezeroku, #174)
Added rbw search, which finds and displays the name of entries matching a given search term.
Added --ignorecase as an option to several subcommands. (Maximilian Götsch, #164)
The JSON output given by --raw now also includes the field type.
Fixed
Fixed the client id used when logging in, which was causing problems with the official Bitwarden server. (Merlin Marek, #186)
Reworked rbw-pinentry-keyring to support passwords with spaces and 2fa codes. (Henk van Maanen, #178)
Try less hard to parse input as a url (so that using rbw get on an entry name containing a : works as expected).
[1.10.2] - 2024-05-20
Fixed
Fix logging into the official Bitwarden server due to changes on their end (Gabriel Górski, #175)
[1.10.1] - 2024-05-08
Added
rbw code supports TOTP codes which use a SHA256 or SHA512 hash (Jonas, #172)
Fixed
Fix rbw code searching by UUID (Robert Günzler, #169)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-3833
Work this was based on: #3255 (had too many merge conflicts so it was just easier to redo the changes in a new branch).
📔 Objective
To clean up the deprecated Register & Prelogin endpoints from API. Updated tests and moved response & request models to Identity.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes