Skip to content

Comments

chore: add issue template and base config#926

Merged
vincentsalucci merged 5 commits intomainfrom
ac/issue-template
Nov 21, 2025
Merged

chore: add issue template and base config#926
vincentsalucci merged 5 commits intomainfrom
ac/issue-template

Conversation

@vincentsalucci
Copy link
Member

📔 Objective

Directory Connector was missing a nice UX for when users create an issue! One has been created that mimics the current Web App experience but has added fields for clarity wrt specific DC related options. The config is copied from the clients repository and contains no changes.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vincentsalucci vincentsalucci self-assigned this Nov 20, 2025
@vincentsalucci vincentsalucci requested a review from a team as a code owner November 20, 2025 22:39
@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 6.87%. Comparing base (2883ff6) to head (5a983aa).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

❗ There is a different number of reports uploaded between BASE (2883ff6) and HEAD (5a983aa). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (2883ff6) HEAD (5a983aa)
2 1
Additional details and impacted files
@@            Coverage Diff            @@
##             main    #926      +/-   ##
=========================================
- Coverage   16.01%   6.87%   -9.14%     
=========================================
  Files          67      67              
  Lines        2791    2791              
  Branches      481     481              
=========================================
- Hits          447     192     -255     
- Misses       2306    2585     +279     
+ Partials       38      14      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2025

Logo
Checkmarx One – Scan Summary & Detailsf19e20d4-b4e7-4642-97cf-2c626b108595

Great job! No new security vulnerabilities introduced in this pull request

@claude
Copy link

claude bot commented Nov 20, 2025

Claude finished @vincentsalucci's task —— View job


Review Complete

  • Check recent commits since last review
  • Read issue template files
  • Verify if review suggestions were addressed
  • Check for any new issues or improvements
  • Post comprehensive review feedback

Summary of Changes Since Last Review

The author has addressed all three suggestions from eliykat's review:

  1. ✅ Separated LDAP implementations (lines 72-73)
  2. ✅ Added clarifying text to Application Type options (lines 87-88)
  3. ✅ Grouped LDAP services together (my suggestion was implemented in commit 5a983aa)

The most recent commits show the iterative refinement of the issue template based on reviewer feedback.


Findings

Finding 1: The PR title and description meet quality standards - title is clear, objective explains the change and rationale, and references to Jira/testing are noted in the checklist.

Finding 2: All reviewer suggestions have been successfully implemented in the most recent commits.


Good Practices Observed

  • Clean YAML formatting with proper indentation
  • Comprehensive issue template covering all necessary fields
  • Appropriate use of required validations on critical fields
  • Clear, user-friendly descriptions for each field
  • Well-structured config.yml with useful contact links

Action Items

None - all review feedback has been addressed. The PR is ready for approval from a human reviewer with merge permissions.


Copy link
Member

@eliykat eliykat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! A couple of suggestions but overall lgtm.

Copy link
Member

@eliykat eliykat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty 🙇

@vincentsalucci vincentsalucci merged commit 99655a0 into main Nov 21, 2025
30 checks passed
@vincentsalucci vincentsalucci deleted the ac/issue-template branch November 21, 2025 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants