[BRE-1302] Revert runner upgrade and target architecture#925
[BRE-1302] Revert runner upgrade and target architecture#925brandonbiete merged 1 commit intomainfrom
Conversation
|
Claude finished @brandonbiete's task —— View job Code Review CompleteSummaryThis PR cleanly reverts the macOS runner upgrade from macos-15 back to macos-13 and changes the target architecture from arm64 back to x64. The revert is a mirror image of PR #918, restoring the previous stable configuration. Changes:
FindingsFinding 1: Consider adding context about why the revert is necessary 💭 The PR description states the objective is to "get back to stable state" but doesn't explain what instability was observed with macos-15/arm64. For future reference and team knowledge, consider documenting:
This information would be valuable in the linked Jira ticket or PR comments. Technical AssessmentCorrectness: ✅ The revert is complete and accurate. All three changes (two runner versions + one architecture target) perfectly mirror the original upgrade. Consistency: ✅ The changes are internally consistent:
Risk:
Good Practices Observed
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #925 +/- ##
==========================================
+ Coverage 10.95% 16.01% +5.05%
==========================================
Files 64 67 +3
Lines 2646 2791 +145
Branches 480 481 +1
==========================================
+ Hits 290 447 +157
+ Misses 2332 2306 -26
- Partials 24 38 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
New Issues (4)Checkmarx found the following issues in this Pull Request
|
BTreston
left a comment
There was a problem hiding this comment.
Build artifact for MacOS gui was fine 👍



🎟️ Tracking
https://bitwarden.atlassian.net/browse/BRE-1302
📔 Objective
Revert runner upgrade and target arch changes to get back to stable state.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes