[PM-26454] Undo removal of core-js to fix dynamic import errors#890
Merged
vincentsalucci merged 2 commits intomainfrom Oct 2, 2025
Merged
[PM-26454] Undo removal of core-js to fix dynamic import errors#890vincentsalucci merged 2 commits intomainfrom
vincentsalucci merged 2 commits intomainfrom
Conversation
Contributor
|
New Issues (1)Checkmarx found the following issues in this Pull Request
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #890 +/- ##
========================================
- Coverage 7.67% 7.67% -0.01%
========================================
Files 68 68
Lines 2775 2776 +1
Branches 482 482
========================================
Hits 213 213
- Misses 2547 2548 +1
Partials 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BTreston
approved these changes
Oct 2, 2025
vincentsalucci
changed the title
vincentsalucci
added a commit
that referenced
this pull request
Oct 2, 2025
* Undo removal of core-js to fix dynamic import errors * chore: update package-lock with npm install --------- Co-authored-by: Vincent Salucci <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-26454
📔 Objective
Fix #878 (maybe). We have been unable to reproduce this error ("A dynamic import callback was not specified.") but my best guess is that removing core-js removed some polyfill required for the node environment.
This PR restores the latest version of core-js we were using to see if it fixes the error.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes