Skip to content

#3533 Feature credit offer overflow validation#3594

Merged
sschiessl-bcp merged 1 commit intobitshares:developfrom
ihorml:feature-credit-offer-overflow-validation
Dec 17, 2022
Merged

#3533 Feature credit offer overflow validation#3594
sschiessl-bcp merged 1 commit intobitshares:developfrom
ihorml:feature-credit-offer-overflow-validation

Conversation

@ihorml
Copy link
Copy Markdown
Contributor

@ihorml ihorml commented Nov 23, 2022

Issue #3533

Description

  • This PR is based on this one - #3567 credit offers edit #3591
  • Catch & detect overflow issues and display a user-friendly error (for create & edit)
  • Add min_loan > total_balance error (for create & edit)

Screenshot 2022-11-23 at 04 29 34

Screenshot 2022-11-23 at 04 29 12

Closes #3533

@sschiessl-bcp
Copy link
Copy Markdown
Contributor

can you rebase please?

@ihorml ihorml force-pushed the feature-credit-offer-overflow-validation branch from dea30f6 to 5ee62ca Compare November 30, 2022 09:44
@ihorml
Copy link
Copy Markdown
Contributor Author

ihorml commented Nov 30, 2022

Done

@sschiessl-bcp sschiessl-bcp merged commit 097f4bb into bitshares:develop Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Credit offer field max limits (field validation)

2 participants