Skip to content

#3575 Display error thrown during credit offer create#3590

Merged
sschiessl-bcp merged 1 commit intobitshares:developfrom
ihorml:feature-fix-credit-offer-create
Nov 18, 2022
Merged

#3575 Display error thrown during credit offer create#3590
sschiessl-bcp merged 1 commit intobitshares:developfrom
ihorml:feature-fix-credit-offer-create

Conversation

@ihorml
Copy link
Copy Markdown
Contributor

@ihorml ihorml commented Nov 17, 2022

Issue #3575

Description

Screenshot 2022-11-17 at 20 24 29

Copy link
Copy Markdown
Member

@abitmore abitmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I think this kind of error reporting can be applied to all operations, but not only on this page or only when creating a credit offer?

Update: Sorry, I thought it's an error returned by the API node, but actually it's by the UI. Please ignore my nonsense above.

if (base.asset_id === quote.asset_id) {
throw new Error("Base and Quote assets must be different");
}

@sschiessl-bcp sschiessl-bcp merged commit 67ecb13 into bitshares:develop Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants