Addition of depositCaching parameter for gateways#3563
Merged
sschiessl-bcp merged 2 commits intobitshares:developfrom Oct 31, 2022
iamredbar:gatewayDepositCaching
Merged
Addition of depositCaching parameter for gateways#3563sschiessl-bcp merged 2 commits intobitshares:developfrom iamredbar:gatewayDepositCaching
sschiessl-bcp merged 2 commits intobitshares:developfrom
iamredbar:gatewayDepositCaching
Conversation
This PR adds functionality to choose whether or not a gateway allows for cached deposit addresses/memos. While being a small change (4 lines), this adds major modular improvement by allowing for gateways with unique deposit requirements. Changes have been added to each active gateway setting this parameter to 'true' to continue with prior UI functionality.
Contributor
|
Please code it in a way that the default value of the flag is inline with existing behavior. |
Member
Author
|
Would you be able to clarify what you mean? |
Contributor
|
You are introducing |
Member
Author
|
Thank you for the clarification. I will refactor. |
- removed hard coded depositCaching properties from gateways config - used ternary operator to evaluate if property depositCaching is present
Member
Author
|
I have updated to comply with non-use of depositCaching property. It uses a ternary operator with the object prototype method .hasOwnProperty. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General
This PR adds functionality to choose whether or not a gateway allows for cached deposit addresses/memos. While being a small change (4 lines), this adds major modular improvement by allowing for gateways with unique deposit requirements. Changes have been added to each active gateway setting this parameter equal to 'true' to continue working with prior UI functionality.
Code Preparation
Testing
The branch has been tested on the following browsers (desktop and mobile view)