Fixing Bug with Credit Fee Amount in Credit Offer#3562
Merged
sschiessl-bcp merged 1 commit intobitshares:developfrom Oct 3, 2022
Merged
Fixing Bug with Credit Fee Amount in Credit Offer#3562sschiessl-bcp merged 1 commit intobitshares:developfrom
sschiessl-bcp merged 1 commit intobitshares:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User had reported the below error while submitting repay credit deal operation:
A core check is rejecting 9 as the credit_fee amount of the operation; it was found that the determination of credit_fee amount is coming through the code equation (fRate * debtAmount * rate); it was solved by rounded up result using Math.ceil()
Testing credits to @thontron