Skip to content

Fixing Float-to-Integer producing too many digits#3547

Merged
sschiessl-bcp merged 1 commit intobitshares:developfrom
ioBanker:patch-19
Sep 18, 2022
Merged

Fixing Float-to-Integer producing too many digits#3547
sschiessl-bcp merged 1 commit intobitshares:developfrom
ioBanker:patch-19

Conversation

@ioBanker
Copy link
Copy Markdown
Member

Closes #3545

@sschiessl-bcp
Copy link
Copy Markdown
Contributor

Does this sove the issue shown in the screen? You are calculating a value in satoshis, and 0.00013 is misrepresented by 129999999998. Rounding the latter should still give you 129999999998?

@ioBanker
Copy link
Copy Markdown
Member Author

Yeah; it solved the issue:

Before:
photo_2022-09-03_20-28-42

After:
photo_2022-09-03_21-15-13

Credits belongs to @christophersanborn

@sschiessl-bcp
Copy link
Copy Markdown
Contributor

You are right, I misjudged

@sschiessl-bcp sschiessl-bcp merged commit ad8cc7d into bitshares:develop Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Float-to-Integer conversion producing too many digits in Liquidity Pool exchange

2 participants