Skip to content

Delete package-lock.json#3426

Merged
sschiessl-bcp merged 1 commit intobitshares:developfrom
abitmore:delete-package-lock-json
Dec 23, 2021
Merged

Delete package-lock.json#3426
sschiessl-bcp merged 1 commit intobitshares:developfrom
abitmore:delete-package-lock-json

Conversation

@abitmore
Copy link
Copy Markdown
Member

General

Closes #3421

Now we have both yarn.lock and package-lock.json in the repository, and package-lock.json is out of sync due to some difficulties.

In #3421 it looks like @dependabot is trying to downgrade node, electron and etc because we didn't sync the package-lock.json file with package.json nor delete it.

By the way, @dependabot thinks it's better to use https://registry.yarnpkg.com/ in yarn.lock (we are using https://registry.npmjs.org/).

General

Please make sure the following is done:

Code Preparation

Please review all your changes one last time before committing

  • Check for unused code
  • No unrelated changes are included
  • None of the changed files are reformatting only
  • Code is self explanatory or documented
  • All written text is properly translated (english language)

Testing

The branch has been tested on the following browsers (desktop and mobile view)

  • Chrome
  • Opera
  • Firefox
  • Safari

User interface changes

Delete this section if there weren't any UI changes. Please make sure you tested your changes in all themes

  • Dark
  • Light
  • Midnight

Please provide screenshots/licecap of your changes below

@sschiessl-bcp sschiessl-bcp merged commit 0f3d5be into bitshares:develop Dec 23, 2021
@abitmore abitmore deleted the delete-package-lock-json branch December 23, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants