Destroy deposit modal cache upon closing it#3388
Merged
sschiessl-bcp merged 1 commit intobitshares:developfrom Jan 31, 2022
Merged
Destroy deposit modal cache upon closing it#3388sschiessl-bcp merged 1 commit intobitshares:developfrom
sschiessl-bcp merged 1 commit intobitshares:developfrom
Conversation
In case platform user owns multiple users and wants to deposit to thus different users; they will need to clear the browser cache every time they want to use different user for deposit modal API data.
Contributor
|
|
Contributor
Author
It clears only the modal’s cache hence the only way to clear modal’s cache in case you want to switch user is to clear browser’s cache. |
Contributor
|
If I don't switch user I still need to fetch the address every time now, don't I? Maybe the modal should check if the username changed? |
Member
|
This will cause that every time you open the deposit modal to pick up the asset you want to choose deposit again; I don't see a reasoning behind keeping old records in modal after closing it, if you have please address. |
Contributor
|
Let's try |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case platform user owns multiple users and wants to deposit to thus different users; they will need to clear the browser cache every time they want to use different user for deposit modal API data.