Fix #3264, get rid of warnings#3380
Merged
sschiessl-bcp merged 7 commits intobitshares:developfrom Jul 16, 2021
freak5g:patch-1
Merged
Fix #3264, get rid of warnings#3380sschiessl-bcp merged 7 commits intobitshares:developfrom freak5g:patch-1
sschiessl-bcp merged 7 commits intobitshares:developfrom
freak5g:patch-1
Conversation
Contributor
|
Generally, dangerouslySetInnerHTML is, well, dangerous. But since the input is controlled this is acceptable. |
Contributor
Author
|
I could split corresponding translation into three parts and format message in render function which works fine; or just remove any formatting at all and keep it simple. I've chosen dangerous approach encouraged by the law of precedent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue 1:
issue 2: