Skip to content

Adding support for BitShares Liquidity Pools (Poolmart)#3378

Merged
sschiessl-bcp merged 80 commits intobitshares:developfrom
AmmarYousefM:develop
Jun 20, 2022
Merged

Adding support for BitShares Liquidity Pools (Poolmart)#3378
sschiessl-bcp merged 80 commits intobitshares:developfrom
AmmarYousefM:develop

Conversation

@AmmarYousefM
Copy link
Copy Markdown
Contributor

@AmmarYousefM AmmarYousefM commented Jul 9, 2021

The PR can be tested at: https://bts.exchange - please test and leave your feedback or comments below.

@AmmarYousefM
Copy link
Copy Markdown
Contributor Author

Does it not bother you to do this in github ui? May I suggest to do a git tutorial to increase your productivity?

I am old school; just leave me alone :P

@sschiessl-bcp
Copy link
Copy Markdown
Contributor

Does it not bother you to do this in github ui? May I suggest to do a git tutorial to increase your productivity?

I am old school; just leave me alone :P

Old school would be using git

@AmmarYousefM
Copy link
Copy Markdown
Contributor Author

Does it not bother you to do this in github ui? May I suggest to do a git tutorial to increase your productivity?

I am old school; just leave me alone :P

Old school would be using git

git is very new to me; I used copy/paste, notepad++ and ancient ninja php programming methods :D

@sschiessl-bcp
Copy link
Copy Markdown
Contributor

Please start using it. Your way is costing you so much more time, let's be efficient.

@sschiessl-bcp
Copy link
Copy Markdown
Contributor

Let me do one holistic review including running this, then we see where we stand.

@sschiessl-bcp sschiessl-bcp force-pushed the develop branch 9 times, most recently from b056a17 to fd99821 Compare March 18, 2022 15:34
@sschiessl-bcp sschiessl-bcp force-pushed the develop branch 2 times, most recently from bc2f1ad to d0a0996 Compare April 23, 2022 09:32
@sschiessl-bcp sschiessl-bcp merged commit 9e4d1d8 into bitshares:develop Jun 20, 2022
@sschiessl-bcp
Copy link
Copy Markdown
Contributor

I switched wording and removed the tabs that only had "Pools" tab. Maybe that can be a Spotlight?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants