Skip to content

Disable RuDEX#3374

Merged
sschiessl-bcp merged 2 commits intodevelopfrom
abitmore-patch-2
Jul 16, 2021
Merged

Disable RuDEX#3374
sschiessl-bcp merged 2 commits intodevelopfrom
abitmore-patch-2

Conversation

@abitmore
Copy link
Copy Markdown
Member

@abitmore abitmore commented May 24, 2021

General

Rudex is being migrated from Bitshares to Graphene:

https://steemit.com/rudex/@rudex/announcement-of-rudex-migration-from-bitshares-to-graphene-dates-and-terms

General

Please make sure the following is done:

Code Preparation

Please review all your changes one last time before committing

  • Check for unused code
  • No unrelated changes are included
  • None of the changed files are reformatting only
  • Code is self explanatory or documented
  • All written text is properly translated (english language)

Testing

The branch has been tested on the following browsers (desktop and mobile view)

  • Chrome
  • Opera
  • Firefox
  • Safari

User interface changes

Delete this section if there weren't any UI changes. Please make sure you tested your changes in all themes

  • Dark
  • Light
  • Midnight

Please provide screenshots/licecap of your changes below

@abitmore abitmore marked this pull request as ready for review May 24, 2021 22:38
@sschiessl-bcp
Copy link
Copy Markdown
Contributor

sschiessl-bcp commented May 25, 2021 •
edited
Loading

We would have the option to immediately show the warning icon, and show the link to the Steem article in the Settings via on-chain config, if desireable?
image

@sschiessl-bcp
Copy link
Copy Markdown
Contributor

sschiessl-bcp commented May 25, 2021 •
edited
Loading

If I remember correctly we can even put a comment with it, would need to test this though.

The respective config part could be changed to something like

"gateways":
{
    "OPEN": { "enabled": false }, 
    "BRIDGE":{ "enabled": false },
    "RUDEX":{ "enabled": false, "comment": "Some message" } 
}

@abitmore
Copy link
Copy Markdown
Member Author

abitmore commented May 25, 2021 •
edited
Loading

I remember the on-chain config feature was discussed, but I'm not sure if it's implemented already. If it's implemented then we don't need to update code every time.

Btw having comments is good too, I wonder where is the best place to show them.

@sschiessl-bcp
Copy link
Copy Markdown
Contributor

sschiessl-bcp commented May 26, 2021 •
edited
Loading

I remember the on-chain config feature was discussed, but I'm not sure if it's implemented already. If it's implemented then we don't need to update code every time.

Btw having comments is good too, I wonder where is the best place to show them.

Connect to the testnet with the UI, then reload (the asset configuration is only loaded in beginning and decides according to the initially connected node).

The config asset is https://develop.bitshares.org/#/asset/NOTIFICATIONS

The assets blacklist is

"blacklists":{ "assets":[ "PRD" ], "accounts":[] }

It shows in the UI like follows
image

Gateway comments are here

 "gateways":{ "OPEN":{ "enabled": false, "comment": "OpenLedger Gateway API Integration is defective." }, ...

The comment shows up at the end of first paragraph
image

So seems to be working alright

@sschiessl-bcp
Copy link
Copy Markdown
Contributor

sschiessl-bcp commented May 26, 2021 •
edited
Loading

Suggestion

This asset is used for decentralized configuration of the BitShares UI placed under bitshares.org. { "notifications":[ { "type":"warning", "begin_date":"21.11.2020", "end_date":"31.12.2021", "content":"SCAM WARNING: BURN option is not a withdrawal. It is actual burn of an asset back to its owner." }, { "type":"critical", "begin_date":"21.11.2020", "end_date":"31.12.2021", "content":"WARNING: Users of the BitShares blockchain, DO NOT ACCEPT suspicious offers to trade tokens on private markets or tokens that are not listed in Withdrawals section of the Wallet UI or in default market pairs." } ], "blacklists":{ "assets":[ ], "accounts":[ ] }, "gateways":{ "OPEN":{ "enabled": false }, "BRIDGE":{ "enabled": false }, "RUDEX":{ "enabled": false, "comment": "RuDEX for Bitshares blockchain is disabled since 27.05.2021, see https://steemit.com/@rudex" } } }

Diff to current description

, "RUDEX":{ "enabled": false, "comment": "RuDEX for Bitshares blockchain is disabled since 27.05.2021, see https://steemit.com/@rudex" }

Question is, when to disable it?

@abitmore
Copy link
Copy Markdown
Member Author

abitmore commented May 31, 2021

@sschiessl-bcp even we can disable a gateway on chain, still need a PR to update Featured Markets, right?

@sschiessl-bcp sschiessl-bcp merged commit ce0bb66 into develop Jul 16, 2021
@sschiessl-bcp sschiessl-bcp deleted the abitmore-patch-2 branch July 16, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@abitmore @sschiessl-bcp