Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General
The old download link no longer works (although it may get fixed at some point). This PR replaces it with a direct link to Github.
By the way, ideally this download link and other links in the same source file E.G. the one used to check for updates should be in
branding.js. But it would be a bigger change thus worth a new pull request IMHO.bitshares-ui/app/components/Layout/Footer.jsx
Line 114 in fce189a
bitshares-ui/app/components/Layout/Footer.jsx
Line 495 in fce189a
Code Preparation
Please review all your changes one last time before committing
Testing
The branch has been tested on the following browsers (desktop and mobile view)
User interface changes
Delete this section if there weren't any UI changes. Please make sure you tested your changes in all themes
Please provide screenshots/licecap of your changes below