Skip to content

Hide own accounts from to field in send modal#3344

Merged
sschiessl-bcp merged 7 commits intobitshares:developfrom
abitmore:hide-linked-accounts
Feb 28, 2021
Merged

Hide own accounts from to field in send modal#3344
sschiessl-bcp merged 7 commits intobitshares:developfrom
abitmore:hide-linked-accounts

Conversation

@abitmore
Copy link
Copy Markdown
Member

@abitmore abitmore commented Feb 24, 2021

General

Workaround for #3343

Add a new property includeMyActiveAccounts to Account Selector, enabled by default, disabled in Send Modal.

BTW updated some checks so that checking for scammers has higher priority.

General

Please make sure the following is done:

Code Preparation

Please review all your changes one last time before committing

  • Check for unused code
  • No unrelated changes are included
  • None of the changed files are reformatting only
  • Code is self explanatory or documented
  • All written text is properly translated (english language)

Testing

The branch has been tested on the following browsers (desktop and mobile view)

  • Chrome
  • Opera
  • Firefox
  • Safari

Please provide screenshots/licecap of your changes below

The screenshot below was for reproducing a scenario that assumes abit-test is the attacker, abit-test2 is the victim, and abit is in contacts.

Without this patch:
image

With the patch, it won't show my accounts at all, which is a bit inconvenient but safer (a test environment is temporarily available at https://pr.bts.mobi/):

image

@abitmore
Copy link
Copy Markdown
Member Author

Updated OP with screenshots.

@sschiessl-bcp sschiessl-bcp merged commit 287ec30 into bitshares:develop Feb 28, 2021
@abitmore abitmore deleted the hide-linked-accounts branch February 28, 2021 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants