Skip to content

Rethrow error when failed to download charting lib#3341

Merged
sschiessl-bcp merged 1 commit intodevelopfrom
rethrow-error
Feb 28, 2021
Merged

Rethrow error when failed to download charting lib#3341
sschiessl-bcp merged 1 commit intodevelopfrom
rethrow-error

Conversation

@abitmore
Copy link
Copy Markdown
Member

@abitmore abitmore commented Feb 22, 2021 •
edited
Loading

In one run of the CI process, the npm ci step went through but npm build failed. Actually npm ci should fail.

More info: https://github.com/abitmore/bitshares-ui/pull/6/checks?check_run_id=1954163481 or https://ci.appveyor.com/project/svk31/bitshares-ui/builds/37891710
(Note: the charting lib downloading issue has been fixed, thus unable to reproduce the issue as is. #3342 reproduces it.)

Run npm ci
...
> [email protected] install-charting-library /home/runner/work/bitshares-ui/bitshares-ui
> node ./charting_library/install-charting-library.js && npm run compile-tv-css

Failed to download charting_library archive
{ Error: connect ETIMEDOUT 149.28.203.167:443
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1107:14)
  errno: 'ETIMEDOUT',
  code: 'ETIMEDOUT',
  syscall: 'connect',
  address: '149.28.203.167',
  port: 443 }

> [email protected] compile-tv-css /home/runner/work/bitshares-ui/bitshares-ui
> node-sass ./charting_library/scss/ --output ./charting_library/ --output-style compressed
...
Run npm build
...
ERROR in ./app/components/Exchange/TradingViewPriceChart.jsx
Module not found: Error: Can't resolve '../../../charting_library/charting_library.esm' in '/home/runner/work/bitshares-ui/bitshares-ui/app/components/Exchange'
...

With the fix (see https://ci.appveyor.com/project/svk31/bitshares-ui/builds/37894611):

Run npm ci
...
> [email protected] install-charting-library C:\projects\bitshares-ui
> node ./charting_library/install-charting-library.js && npm run compile-tv-css
Failed to download charting_library archive
{ Error: connect ETIMEDOUT 10.255.255.1:443
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1107:14)
  errno: 'ETIMEDOUT',
  code: 'ETIMEDOUT',
  syscall: 'connect',
  address: '10.255.255.1',
  port: 443 }
C:\projects\bitshares-ui\charting_library\install-charting-library.js:21
    throw (err);
    ^
Error: connect ETIMEDOUT 10.255.255.1:443
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1107:14)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] install-charting-library: `node ./charting_library/install-charting-library.js && npm run compile-tv-css`
npm ERR! Exit status 1
...

@abitmore abitmore mentioned this pull request Feb 22, 2021
Closed
@sschiessl-bcp
Copy link
Copy Markdown
Contributor

sschiessl-bcp commented Feb 28, 2021

Good call thx

@sschiessl-bcp sschiessl-bcp merged commit 9132651 into develop Feb 28, 2021
@abitmore abitmore deleted the rethrow-error branch July 28, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@abitmore @sschiessl-bcp