Skip to content

add es wrapper from blocksights#3324

Merged
sschiessl-bcp merged 1 commit intodevelopfrom
add/es-wrapper
Jan 18, 2021
Merged

add es wrapper from blocksights#3324
sschiessl-bcp merged 1 commit intodevelopfrom
add/es-wrapper

Conversation

@sschiessl-bcp
Copy link
Copy Markdown
Contributor

@sschiessl-bcp sschiessl-bcp commented Jan 17, 2021

No description provided.

abitmore
abitmore approved these changes Jan 17, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@abitmore abitmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. What do I need to do?

@sschiessl-bcp sschiessl-bcp merged commit bc36b5b into develop Jan 18, 2021
@abitmore
Copy link
Copy Markdown
Member

abitmore commented Jan 18, 2021

It seems the "DOWNLOAD HISTORY" link was removed?

@abitmore
Copy link
Copy Markdown
Member

abitmore commented Jan 18, 2021

Oh, I was wrong. The link does not appear on https://develop.bitshares.org/ because the latest code is not automatically deployed, since the deployment process relies on travis-ci.org which is no longer available (see #3302).

@abitmore
Copy link
Copy Markdown
Member

abitmore commented Jan 18, 2021

Hmm.. actually CI is working but found errors

/home/travis/build/bitshares/bitshares-ui/charting_library/install-charting-library.js:27
        throw new Error("MD5 of downloaded file (" + actualDigest + ") not matches expected (" + expectedDigest + ")");
        ^
Error: MD5 of downloaded file (78ED0E5F1AD165343A2D18A6C0FC433E) not matches expected (0F4B4F04A2BD6511722F666CA89248D1)

@abitmore
Copy link
Copy Markdown
Member

abitmore commented Jan 18, 2021

It seems the file was hosted on bitshares.org but got removed now. Will fix.

@abitmore abitmore deleted the add/es-wrapper branch January 18, 2021 22:55
@abitmore
Copy link
Copy Markdown
Member

abitmore commented Jan 18, 2021

Please check #3325 for latest info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abitmore abitmore abitmore approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sschiessl-bcp @abitmore