Make bridge withdrawals based on mapping data#3235
Merged
sschiessl-bcp merged 1 commit intobitshares:developfrom Apr 27, 2020
Merged
Make bridge withdrawals based on mapping data#3235sschiessl-bcp merged 1 commit intobitshares:developfrom
sschiessl-bcp merged 1 commit intobitshares:developfrom
Conversation
Contributor
|
Is the current implementation still working? What is the purpose of the new mapping data? |
Contributor
|
For the bitshares bridge, we use to use a memo system like "btc:my_receive_address". Now the memo is a UUID. I forget all the reasons for the change, but it's something we want. |
Contributor
|
Merged, only affects Blocktrades. If you want or can, I would be interested in hearing the reasons behind the change @dnotestein |
Contributor
|
The release candidate is out, could you please test your integration? #3251 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General
Blocktrades bridge has functionality in wich users can do withdrawals. Memo information is now based on data which are getting from new mapping API call.
Code Preparation
Please review all your changes one last time before committing
Testing
The branch has been tested on the following browsers (desktop and mobile view)
There were not changes in UI.