Skip to content

Collateral is not part of total value#3204

Merged
sschiessl-bcp merged 1 commit intobitshares:developfrom
froooze:patch-1
May 3, 2020
Merged

Collateral is not part of total value#3204
sschiessl-bcp merged 1 commit intobitshares:developfrom
froooze:patch-1

Conversation

@froooze
Copy link
Copy Markdown
Collaborator

@froooze froooze commented Feb 21, 2020

General

Closes #[Insert issue number]

[Insert description of what you did, any description how to test or check your changes are welcome]

General

Please make sure the following is done:

Code Preparation

Please review all your changes one last time before committing

  • Check for unused code
  • No unrelated changes are included
  • None of the changed files are reformatting only
  • Code is self explanatory or documented
  • All written text is properly translated (english language)

Testing

The branch has been tested on the following browsers (desktop and mobile view)

  • Chrome
  • Opera
  • Firefox
  • Safari

User interface changes

Delete this section if there weren't any UI changes. Please make sure you tested your changes in all themes

  • Dark
  • Light
  • Midnight

Please provide screenshots/licecap of your changes below

@litepresence
Copy link
Copy Markdown
Contributor

Also vesting balances are not part of total value, maybe they should be added as well?

@froooze
Copy link
Copy Markdown
Collaborator Author

froooze commented Feb 25, 2020

Also vesting balances are not part of total value, maybe they should be added as well?

Vesting balances belong after a certain time to the user?

@sschiessl-bcp sschiessl-bcp merged commit 632e21d into bitshares:develop May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants