Rethrow more asio operation cancellation exception as fc::canceled_exception#251
Merged
Rethrow more asio operation cancellation exception as fc::canceled_exception#251
fc::canceled_exception#251Conversation
... `boost::asio::error::operation_aborted` as `fc::canceled_exception` instead of `fc::exception` in read/write handlers
|
SonarCloud Quality Gate failed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.










Rethrow more asio operation cancellation exception
boost::asio::error::operation_abortedasfc::canceled_exceptioninstead offc::exceptionin read/write handlers to fix errors like below.See also #249.
Note that this PR and #249 essentially revert f8472af and a part of 751777e . The commit f8472af says:
But I think async task cancellation will trigger socket operation abortion, we need a
fc::calceled_exceptionto handle it correctly.