Enable publishing of macOS wheel #1818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates our packaging workflow to build and publish wheels for macOS 14+ on arm64.
We've had passing tests on M1 CPU in our CI for quite a while now, and these tests also pass on the MPS device on an M4 MacBook Pro.
All of the MPS ops have naive/slower implementations in pure PyTorch, while some CPU ops have implementations in C++. For now this will provide a baseline implementation that can bring some parity to macOS for development/testing purposes. We'll continue to explore the addition of Metal kernels to improve performance in the future.
It's important to note that the 32bit and 8bit optimizers are not yet supported on CPU on any platform. On macOS they are also not yet supported for MPS.
Resolves #1020, #252