-
-
Notifications
You must be signed in to change notification settings - Fork 800
Drop Python 3.9 support #1795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Python 3.9 support #1795
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
| "Programming Language :: Python :: 3.11", | ||
| "Programming Language :: Python :: 3.12", | ||
| "Programming Language :: Python :: 3.13", | ||
| "Programming Language :: Python :: 3.14", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matthewdouglas, have you tested on Python 3.14? We are getting this error on trl: huggingface/trl#4225 (comment)
import bitsandbytes as bnb
.venv/lib/python3.14/site-packages/bitsandbytes/__init__.py:19: in <module>
from .backends.default import ops as default_ops
.venv/lib/python3.14/site-packages/bitsandbytes/backends/default/ops.py:324: in <module>
@torch.compile
^^^^^^^^^^^^^
.venv/lib/python3.14/site-packages/torch/__init__.py:2590: in compile
raise RuntimeError("torch.compile is not supported on Python 3.14+")
E RuntimeError: torch.compile is not supported on Python 3.14+There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@albertvillanova Thanks for pointing that out. I think it's likely to work with torch nightly, but haven't tested it on the main releases. We probably need to better guard our use of the @torch.compile decorator. Will add that to our backlog.
bitsandbytes 0.47.0 may actually work with Python 3.14 for the time being, as it doesn't have this use of torch.compile in it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick follow-up and the additional context. 🤗
We'll keep an eye on the progress regarding the @torch.compile guarding and the compatibility updates. We'll also test with bitsandbytes 0.47.0 once released as suggested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@albertvillanova bitsandbytes==0.47.0 is a past existing release that can be used today (current is 0.48.2). Since we didn't have that usage of torch.compile I would expect it to just work, but it would be broken in 0.48+.
I'm planning to get a v0.49.0 release out by end of year, and will create a new issue for this and make sure to include it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@albertvillanova #1831 should fix this!
Removes support for Python 3.9.
Additionally, Ruff is upgraded and fixes made as appropriate.
Resolves #1777