This repository was archived by the owner on Apr 3, 2019. It is now read-only.
Networks: Added regtest to networks #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brings better compatibility between "testnet" and "regtest". Services such as Bitcore Wallet Service and wallets such as Copay that have "testnet" and not "regtest" will be compatible with "regtest" if enabled in a Bitcore node. This adds two new API methods to enable/disable regtest on the testnet network: - `bitcore.Networks.enableRegtest()` - `bitcore.Networks.disableRegtest()`
Contributor
|
👍 |
Contributor
|
reviewing... |
Contributor
|
Looks good to me. I npm linked this to a bitcore node with the following patch braydonf/bitcore-node@6e8f3ee and set my bitcore-node.json network to "regtest". The node runs fine. I connected it to a separate bitcoin qt regtest node and it synced up. I ran insight-api, insight-ui, and bitcore-wallet-service on the bitcore node. Insight worked properly, copay worked properly and I was able to send funds between copay and bitcoin qt. There is only one issue. On the status page of insight, under "bitcoin node information", it says testnet is false. This can be changed to simply display the network name instead of a boolean, but I think that is beyond the scope of this issue. see bitpay/insight#702 |
gabegattis
added a commit
that referenced
this pull request
Feb 4, 2016
Networks: Added regtest to networks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings better compatibility between "testnet" and "regtest". Services such as
Bitcore Wallet Service and wallets such as Copay that have "testnet" and not
"regtest" will be compatible with "regtest" if enabled in a Bitcore node. This
adds two new API methods to enable/disable regtest on the testnet network:
bitcore.Networks.enableRegtest()bitcore.Networks.disableRegtest()Closes: bitpay/bitcore#1190