remove hdkeycache #117
remove hdkeycache #117
Conversation
|
What is the motivation for this? Key derivation is VERY slow in JS. |
|
Regarding the speed of derivation, FWIW: https://github.com/cryptocoinjs/hdkey implements derivivaiton using secp256k1 C bindings which is much faster, and bcoin has also started to do something similar at https://github.com/bcoin-org/bcoin/tree/master/lib/hd though is still using cache. |
|
Right. That would be great but we also need key derivation in pure JS for
the browser (for copay for example)
…On Dec 8, 2016 10:44, "Braydon Fuller" ***@***.***> wrote:
Regarding the speed of derivation, FWIW: https://github.com/
cryptocoinjs/hdkey implements derivivaiton using secp256k1 C bindings
which is much faster, and bcoin has also started to do something similar at
https://github.com/bcoin-org/bcoin/tree/master/lib/hd though is still
using cache.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#117 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAGCHEDDKB-wl_KuW_PWiPxLqKLPaTdnks5rGAnYgaJpZM4LHBpJ>
.
|
|
@matiu How often are we actually re-deriving a key that we previously derived? It seems like that would be a very rare situation. We don't reuse addresses in Copay, so it seems like we would normally just derive a key once and never need it again. |
|
@gabegattis based on conversations, both in this thread and external, is this code still ready to merge? |
|
ACK |
1 similar comment
|
ACK |
6 participants
#96