bitnami/zipkin Remove quote for the host#31866
Merged
gongomgra merged 2 commits intobitnami:mainfrom Feb 11, 2025
Merged
Conversation
Signed-off-by: Peter Trekels <[email protected]>
Contributor
Author
|
More information can be found in : #31374 |
4 tasks
Signed-off-by: Bitnami Containers <[email protected]>
carrodher
added
verify
gongomgra
approved these changes
Feb 11, 2025
Contributor
|
Thanks for your contribution! |
steffenboe
pushed a commit
to steffenboe/charts
that referenced
this pull request
Feb 20, 2025
* bitnami/zipkin Remove quote for the host Signed-off-by: Peter Trekels <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Peter Trekels <[email protected]> Signed-off-by: Bitnami Containers <[email protected]> Co-authored-by: Peter Trekels <[email protected]> Co-authored-by: Bitnami Containers <[email protected]> Signed-off-by: Steffen Börner <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Removed the quote from the host value so it can be combined in configmap with the port.
Benefits
Now it is possible to use external database.
Possible drawbacks
None
Applicable issues
None
Additional information
None
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm