[bitnami/rabbitmq]: add hostPort support to the chart#31836
Merged
dgomezleon merged 5 commits intobitnami:mainfrom Feb 10, 2025
Merged
[bitnami/rabbitmq]: add hostPort support to the chart#31836dgomezleon merged 5 commits intobitnami:mainfrom
dgomezleon merged 5 commits intobitnami:mainfrom
Conversation
Signed-off-by: metron2 <[email protected]>
Signed-off-by: Derek Griffiths <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
carrodher
added
verify
Signed-off-by: Bitnami Containers <[email protected]>
dgomezleon
approved these changes
Feb 10, 2025
Member
dgomezleon
left a comment
dgomezleon
left a comment
There was a problem hiding this comment.
LGTM. Thanks for contributing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
This is a fairly simple change to allow chart users to use hostPorts with RabbitMQ. This makes it very easy to deploy the chart on bare metal clusters.
Benefits
When deploying on baremetal using
nodeAffinityPreset.type=hardthis makes it really easy to use kubernetes instead of docker.Possible drawbacks
There are not really any drawbacks because hostPort is disabled by default.
Applicable issues
Additional information
The RabbitMQ cluster operator supports hostPort, so this is just bringing parity to the chart.
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm