@fmulero indeed the error is in that line 16 of the configmap template. As the host string would be quoted there this would introduce something like "aa.bb.com":1234 This of course is no legal yaml syntax and so my helm complained about it.

Steps to reproduce it was simply trying to use an external cassandra db..

And printf fix is indeed also possible and maybe a better fix.

@fmulero indeed the error is in that line 16 of the configmap template. As the host string would be quoted there this would introduce something like "aa.bb.com":1234 This of course is no legal yaml syntax and so my helm complained about it.

Steps to reproduce it was simply trying to use an external cassandra db..

And printf fix is indeed also possible and maybe a better fix.

Got it. Could you go ahead with the proposed change?

I did not used this fix correctly until now it seems. And it seems there is still an issue. The zipkin.cassandra.host is quoted and so introduces the issue I think.

CASSANDRA_CONTACT_POINTS: {{ printf "%s:%d" ( include "zipkin.cassandra.host" . | replace """ "" ) ( include "zipkin.cassandra.port" . | int ) }}

'unquoting' it seems to fix the issue for me, but don't now if this is the best solution?

@fmulero : what would you propose?

Sorry @ptrekelsseg I don't fully understand, What issue are you facing now? Could you share how to reproduce it?

I'm simply using a values file like this:

storageType: cassandra3

externalDatabase:
  host: cascluster-dev-service
  port: 9042
  user: cassandra-zipkin
  existingSecret: cascluster-user-zipkin
  existingSecretPasswordKey: password
  cluster:
    datacenter: dev
  keyspace: bitnami_zipkin
cassandra:
  enabled: false

I checked out the bitnami charts locally and I'm able to reproduce the issue with:

helm template test bitnami/charts/bitnami/zipkin/ --values testoverlays/dev/zipkin-values.yaml --show-only templates/configmap.yaml

Here the external db host value is quoted: https://github.com/bitnami/charts/blob/main/bitnami/zipkin/templates/_helpers.tpl#L32
And here it is used: https://github.com/bitnami/charts/blob/main/bitnami/zipkin/templates/configmap.yaml#L16

And like I said, I tested your change. But was wrong and I was still using my old fix.. So I did not notice your fix still gives an issue.

and to give you all the info, the output of the command is:

---
# Source: zipkin/templates/configmap.yaml
apiVersion: v1
kind: ConfigMap
metadata:
  name: test-zipkin
  namespace: "segdev"
  labels:
    app.kubernetes.io/instance: test
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/name: zipkin
    app.kubernetes.io/version: 3.4.4
    helm.sh/chart: zipkin-1.1.3
    app.kubernetes.io/component: zipkin
    app.kubernetes.io/part-of: zipkin
data:
  Error: 'error converting YAML to JSON: yaml: line 5: did not find expected key'

2 possible solutions I tested:

CASSANDRA_CONTACT_POINTS: {{ printf "%s:%d" ( trimAll "\"" (include "zipkin.cassandra.host" .) )  ( include "zipkin.cassandra.port" . | int ) }}
CASSANDRA_CONTACT_POINTS2: {{ printf "%s:%d" ( include "zipkin.cassandra.host" . | replace "\"" "" ) ( include "zipkin.cassandra.port" . | int ) }}

Or the 3e solution of course removing the quote in the helpers template:

diff --git a/bitnami/zipkin/templates/_helpers.tpl b/bitnami/zipkin/templates/_helpers.tpl
index ab0cd9534e..dcf39107d9 100644
--- a/bitnami/zipkin/templates/_helpers.tpl
+++ b/bitnami/zipkin/templates/_helpers.tpl
@@ -29,7 +29,7 @@ Create the cassandra host
 */}}
 {{- define "zipkin.cassandra.host" -}}
     {{- if not .Values.cassandra.enabled -}}
-        {{- .Values.externalDatabase.host | quote -}}
+        {{- .Values.externalDatabase.host -}}
     {{- else -}}
         {{- include "common.names.dependency.fullname" (dict "chartName" "cassandra" "chartValues" .Values.cassandra "context" $) -}}
     {{- end }}

zipkin.cassandra.host is also used in ./zipkin/templates/_init_containers.tpl so it will now be unquoted there also, or we can re-add the quote call there.

@fmulero : I pushed a proposal in #31866