bitnami/postgresql Fix missing dot in include statement for passwordUpdate job template by nix-power · Pull Request #31364 · bitnami/charts

nix-power · 2025-01-14T18:03:05Z

Description of the change

Benefits

Fix missing dot in include statement for passwordUpdate job template

Error: template: idp/charts/keycloak/charts/postgresql/templates/update-password/job.yaml:60:37: 
executing "idp/charts/keycloak/charts/postgresql/templates/update-password/job.yaml" 
at <include>: wrong number of args for include: want 2 got 1

Possible drawbacks

Applicable issues

fixes # Bug of rendering of paswordUpdate job

Additional information

Chart has been rendered locally (as a subchart of keycloak) and the issue appears fixed

# Source: idp/charts/keycloak/charts/postgresql/templates/update-password/job.yaml
apiVersion: batch/v1
kind: Job
metadata:
  name: idp-postgresql-password-update
  namespace: "idp"
  labels:
    app.kubernetes.io/instance: idp
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/name: postgresql
    app.kubernetes.io/version: 17.2.0
    helm.sh/chart: postgresql-16.4.2
    app.kubernetes.io/part-of: postgresql
    app.kubernetes.io/component: update-job
  annotations:
    helm.sh/hook: pre-upgrade
    helm.sh/hook-delete-policy: hook-succeeded
spec:
  backoffLimit: 10
  template:
    metadata:
      labels:
        app.kubernetes.io/instance: idp
        app.kubernetes.io/managed-by: Helm
        app.kubernetes.io/name: postgresql
        app.kubernetes.io/version: 17.2.0
        helm.sh/chart: postgresql-16.4.2
        app.kubernetes.io/part-of: postgresql
        app.kubernetes.io/component: update-job
    spec:

      restartPolicy: OnFailure
      securityContext:
        fsGroup: 1001
        fsGroupChangePolicy: Always
        supplementalGroups: []
        sysctls: []
      automountServiceAccountToken: false
      initContainers:
      containers:
        - name: update-credentials
          image: rt.imperva-services.net/docker/postgresql:16.6.0-debian-12-r2
          imagePullPolicy: Always
          command:
            - /bin/bash
            - -ec
          args:
            - |

              . /opt/bitnami/scripts/postgresql-env.sh
              . /opt/bitnami/scripts/libpostgresql.sh
              . /opt/bitnami/scripts/liblog.sh

              primary_host=idp-postgresql-0.idp-postgresql-hl
              info "Starting password update job"
              if [[ -f /job-status/postgres-password-changed ]]; then
                  info "Postgres password already updated. Skipping"
              else
                  info "Updating postgres password"
                  echo "ALTER USER postgres WITH PASSWORD '$POSTGRESQL_NEW_POSTGRES_PASSWORD';" | postgresql_remote_execute $primary_host 5432 "" postgres $POSTGRESQL_PREVIOUS_POSTGRES_PASSWORD
                  touch /job-status/postgres-password-changed
                  info "Postgres password successfully updated"
              fi
              if [[ -f /job-status/password-changed ]]; then
                  info "User password already updated. Skipping"
              else
                  info "Updating user password"
                  echo "ALTER USER ico_keycloak WITH PASSWORD '$POSTGRESQL_NEW_PASSWORD';" | postgresql_remote_execute $primary_host 5432 "keycloak" $POSTGRESQL_USER $POSTGRESQL_PREVIOUS_PASSWORD
                  touch /job-status/password-changed
                  info "User password successfully updated"
              fi
              info "Password update job finished successfully"

Checklist

[ X] Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
[ X] Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
[ X] All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Signed-off-by: Dima Zyuryaev <[email protected]>

nix-power · 2025-01-14T18:12:47Z

If possible, please prioritize this.

Signed-off-by: Bitnami Containers <[email protected]>

carrodher

Thanks, LGTM

Fix missing dot in include statement for passwordUpdate job

d0990b6

Signed-off-by: Dima Zyuryaev <[email protected]>

github-actions bot added postgresql triage Triage is needed labels Jan 14, 2025

github-actions bot assigned javsalgar Jan 14, 2025

github-actions bot requested a review from javsalgar January 14, 2025 18:03

Bumping chart yaml for CI

65ad227

Signed-off-by: Dima Zyuryaev <[email protected]>

nix-power marked this pull request as ready for review January 14, 2025 18:12

Update CHANGELOG.md

b43c9af

Signed-off-by: Bitnami Containers <[email protected]>

nix-power mentioned this pull request Jan 14, 2025

passwordUpdate job is missing "." in include statement #31367

Closed

carrodher added verify Execute verification workflow for these changes in-progress labels Jan 14, 2025

github-actions bot removed the triage Triage is needed label Jan 14, 2025

github-actions bot unassigned javsalgar Jan 14, 2025

github-actions bot removed the request for review from javsalgar January 14, 2025 21:05

github-actions bot assigned dgomezleon Jan 14, 2025

github-actions bot requested a review from dgomezleon January 14, 2025 21:05

carrodher approved these changes Jan 14, 2025

View reviewed changes

carrodher enabled auto-merge (squash) January 14, 2025 21:05

carrodher merged commit 901b26c into bitnami:main Jan 14, 2025

github-actions bot added solved and removed in-progress labels Jan 14, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bitnami/postgresql Fix missing dot in include statement for passwordUpdate job template#31364

bitnami/postgresql Fix missing dot in include statement for passwordUpdate job template#31364
carrodher merged 3 commits intobitnami:mainfrom
nix-power:patch-2

nix-power commented Jan 14, 2025 •

edited by carrodher

Loading

Uh oh!

nix-power commented Jan 14, 2025

Uh oh!

carrodher left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

nix-power commented Jan 14, 2025 • edited by carrodher Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of the change

Benefits

Possible drawbacks

Applicable issues

Additional information

Checklist

Uh oh!

nix-power commented Jan 14, 2025

Uh oh!

carrodher left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nix-power commented Jan 14, 2025 •

edited by carrodher

Loading