Skip to content

[bitnami/postgresql] metrics.collectors applies to read replicas#30133

Merged
juan131 merged 5 commits intobitnami:mainfrom
GIScience:fix/postgresql_metrics_collectors_for_replicas
Nov 4, 2024
Merged

[bitnami/postgresql] metrics.collectors applies to read replicas#30133
juan131 merged 5 commits intobitnami:mainfrom
GIScience:fix/postgresql_metrics_collectors_for_replicas

Conversation

@dklenke
Copy link
Copy Markdown
Contributor

@dklenke dklenke commented Oct 30, 2024

Description of the change

When architecture: replication as well as metrics.enabled: true and metrics.collectors.postmaster: true are set (any collector works here, postmaster used as example) this change makes the read replicas metrics containers start with the relevant collector args.

Benefits

Consistent behavior when enabling metrics collectors in replication mode.

Possible drawbacks

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@dklenke
Copy link
Copy Markdown
Contributor Author

dklenke commented Oct 30, 2024

I see that the github actions were unable to push to my fork but I am missing the knowledge of how to fix that. I invited the bitnami-bot to the project but the invite is pending

@carrodher
Copy link
Copy Markdown
Member

Thanks for your contribution! As you rightly said, inviting bitnami-bot to your fork is enough, we just accepted the invitation.
At this moment, please note GitHub is reporting some conflicts that must be resolved before merging the PR, could you please rebase from main resolving the conflicts?

Dario Klenke and others added 5 commits October 31, 2024 09:40
Signed-off-by: Bitnami Containers <[email protected]>
This reverts commit a0258e2.

Signed-off-by: Dario Klenke <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
@dklenke
Copy link
Copy Markdown
Contributor Author

dklenke commented Oct 31, 2024

Hi, I resolved the merge conflict but now the changelog for some reason has moved the 16.1.0 update to the 30.10 instead of the 29.10. I tried to revert my changes to the file but the bot reintroduced them. I hope this is not an issue

@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Oct 31, 2024
@github-actions github-actions bot removed the triage Triage is needed label Oct 31, 2024
@github-actions github-actions bot removed the request for review from carrodher October 31, 2024 17:08
@github-actions github-actions bot requested a review from juan131 October 31, 2024 17:09
Copy link
Copy Markdown
Contributor

@juan131 juan131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! LGTM

@juan131 juan131 merged commit 696f113 into bitnami:main Nov 4, 2024
@dklenke dklenke deleted the fix/postgresql_metrics_collectors_for_replicas branch November 4, 2024 12:58
@robcresswell
Copy link
Copy Markdown

This is giving me the following issue, I think:

/opt/bitnami/scripts/libpostgresql.sh: line 395: POSTGRESQL_REPLICATION_USE_PASSFILE: unbound variable

pinning to 16.1.0 makes the issue go away

project-mirrors-bot-tu bot pushed a commit to project-mirrors/gitea-helm-chart that referenced this pull request Feb 5, 2025
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [postgresql](https://github.com/bitnami/charts) ([source](https://github.com/bitnami/charts/tree/HEAD/bitnami/postgresql)) | major | `15.5.38` -> `16.4.6` |

---

### Release Notes

<details>
<summary>bitnami/charts (postgresql)</summary>

### [`v16.4.6`](https://github.com/bitnami/charts/blob/HEAD/bitnami/postgresql/CHANGELOG.md#1646-2025-02-02)

-   \[bitnami/postgresql] Release 16.4.6 ([#&#8203;31702](bitnami/charts#31702))

### [`v16.4.5`](https://github.com/bitnami/charts/blob/HEAD/bitnami/postgresql/CHANGELOG.md#small1645-2025-01-20-small)

-   \[bitnami/postgresql] Release 16.4.5 ([#&#8203;31484](bitnami/charts#31484)) ([b11637c](bitnami/charts@b11637c)), closes [#&#8203;31484](bitnami/charts#31484)

### [`v16.4.4`](https://github.com/bitnami/charts/blob/HEAD/bitnami/postgresql/CHANGELOG.md#small1644-2025-01-20-small)

-   \[bitnami/postgresql] Release 16.4.4 ([#&#8203;31482](bitnami/charts#31482)) ([e784f18](bitnami/charts@e784f18)), closes [#&#8203;31482](bitnami/charts#31482)

### [`v16.4.3`](https://github.com/bitnami/charts/blob/HEAD/bitnami/postgresql/CHANGELOG.md#small1643-2025-01-14-small)

-   bitnami/postgresql Fix missing dot in include statement for passwordUpdate job template ([#&#8203;31364](bitnami/charts#31364)) ([901b26c](bitnami/charts@901b26c)), closes [#&#8203;31364](bitnami/charts#31364)

### [`v16.4.2`](https://github.com/bitnami/charts/blob/HEAD/bitnami/postgresql/CHANGELOG.md#small1642-2025-01-13-small)

-   \[bitnami/postgresql] Release 16.4.2 ([#&#8203;31342](bitnami/charts#31342)) ([946b638](bitnami/charts@946b638)), closes [#&#8203;31342](bitnami/charts#31342)

### [`v16.4.1`](https://github.com/bitnami/charts/blob/HEAD/bitnami/postgresql/CHANGELOG.md#small1641-2025-01-13-small)

-   Dynamic assignment of custom schema name if defined in update-password job ([#&#8203;31146](bitnami/charts#31146)) ([364ac45](bitnami/charts@364ac45)), closes [#&#8203;31146](bitnami/charts#31146)

### [`v16.3.5`](https://github.com/bitnami/charts/blob/HEAD/bitnami/postgresql/CHANGELOG.md#small1635-2025-01-03-small)

-   Revert "\[bitnami/postgresql] Add Storage Class Configuration to Templates ([#&#8203;30858](bitnami/charts#30858))" ([#&#8203;31204](bitnami/charts#31204)) ([c03fe0c](bitnami/charts@c03fe0c)), closes [#&#8203;30858](bitnami/charts#30858) [#&#8203;31204](bitnami/charts#31204)

### [`v16.3.4`](https://github.com/bitnami/charts/blob/HEAD/bitnami/postgresql/CHANGELOG.md#small1634-2024-12-23-small)

-   \[bitnami/postgresql] Release 16.3.4 ([#&#8203;31143](bitnami/charts#31143)) ([05a9583](bitnami/charts@05a9583)), closes [#&#8203;31143](bitnami/charts#31143)

### [`v16.3.3`](https://github.com/bitnami/charts/blob/HEAD/bitnami/postgresql/CHANGELOG.md#small1633-2024-12-20-small)

-   \[bitnami/postgresql] Release 16.3.3 ([#&#8203;31133](bitnami/charts#31133)) ([41671f2](bitnami/charts@41671f2)), closes [#&#8203;31133](bitnami/charts#31133)

### [`v16.3.2`](https://github.com/bitnami/charts/blob/HEAD/bitnami/postgresql/CHANGELOG.md#small1632-2024-12-16-small)

-   \[bitnami/\*] Fix typo in README ([#&#8203;31052](bitnami/charts#31052)) ([b41a51d](bitnami/charts@b41a51d)), closes [#&#8203;31052](bitnami/charts#31052)
-   \[bitnami/postgresql] Release 16.3.2 ([#&#8203;31060](bitnami/charts#31060)) ([1406ab1](bitnami/charts@1406ab1)), closes [#&#8203;31060](bitnami/charts#31060)

### [`v16.3.1`](https://github.com/bitnami/charts/blob/HEAD/bitnami/postgresql/CHANGELOG.md#small1631-2024-12-13-small)

-   \[bitnami/postgresql] Add Storage Class Configuration to Templates ([#&#8203;30858](bitnami/charts#30858)) ([b0d2c2e](bitnami/charts@b0d2c2e)), closes [#&#8203;30858](bitnami/charts#30858)

### [`v16.3.0`](https://github.com/bitnami/charts/blob/HEAD/bitnami/postgresql/CHANGELOG.md#1630-2024-12-10)

-   \[bitnami/\*] Add Bitnami Premium to NOTES.txt ([#&#8203;30854](bitnami/charts#30854)) ([3dfc003](bitnami/charts@3dfc003)), closes [#&#8203;30854](bitnami/charts#30854)
-   \[bitnami/postgresql] Detect non-standard images ([#&#8203;30936](bitnami/charts#30936)) ([ac96151](bitnami/charts@ac96151)), closes [#&#8203;30936](bitnami/charts#30936)

### [`v16.2.5`](https://github.com/bitnami/charts/blob/HEAD/bitnami/postgresql/CHANGELOG.md#small1625-2024-12-03-small)

-   \[bitnami/postgresql] Release 16.2.5 ([#&#8203;30733](bitnami/charts#30733)) ([34606c1](bitnami/charts@34606c1)), closes [#&#8203;30733](bitnami/charts#30733)

### [`v16.2.4`](https://github.com/bitnami/charts/blob/HEAD/bitnami/postgresql/CHANGELOG.md#small1624-2024-12-03-small)

-   \[bitnami/\*] docs: 📝 Add "Backup & Restore" section ([#&#8203;30711](bitnami/charts#30711)) ([35ab536](bitnami/charts@35ab536)), closes [#&#8203;30711](bitnami/charts#30711)
-   \[bitnami/\*] docs: 📝 Add "Prometheus metrics" (batch 5) ([#&#8203;30674](bitnami/charts#30674)) ([ed2a546](bitnami/charts@ed2a546)), closes [#&#8203;30674](bitnami/charts#30674)
-   \[bitnami/postgresql] use adminPassword for metrics user when custom user is not set ([#&#8203;30720](bitnami/charts#30720)) ([8f4bc7b](bitnami/charts@8f4bc7b)), closes [#&#8203;30720](bitnami/charts#30720)

### [`v16.2.3`](https://github.com/bitnami/charts/blob/HEAD/bitnami/postgresql/CHANGELOG.md#small1623-2024-11-28-small)

-   \[bitnami/postgresql] Release 16.2.3 ([#&#8203;30645](bitnami/charts#30645)) ([22a4c51](bitnami/charts@22a4c51)), closes [#&#8203;30645](bitnami/charts#30645)

### [`v16.2.2`](https://github.com/bitnami/charts/blob/HEAD/bitnami/postgresql/CHANGELOG.md#small1622-2024-11-21-small)

-   \[bitnami/postgresql] Release 16.2.2 ([#&#8203;30570](bitnami/charts#30570)) ([7b3a6d5](bitnami/charts@7b3a6d5)), closes [#&#8203;30570](bitnami/charts#30570)

### [`v16.2.1`](https://github.com/bitnami/charts/blob/HEAD/bitnami/postgresql/CHANGELOG.md#small1621-2024-11-14-small)

-   \[bitnami/postgresql] Release 16.2.1 ([#&#8203;30463](bitnami/charts#30463)) ([2360527](bitnami/charts@2360527)), closes [#&#8203;30463](bitnami/charts#30463)

### [`v16.2.0`](https://github.com/bitnami/charts/blob/HEAD/bitnami/postgresql/CHANGELOG.md#1620-2024-11-14)

-   \[bitnami/postgresql] feat: ✨ Add password update job ([#&#8203;30444](bitnami/charts#30444)) ([ea896db](bitnami/charts@ea896db)), closes [#&#8203;30444](bitnami/charts#30444)

### [`v16.1.2`](https://github.com/bitnami/charts/blob/HEAD/bitnami/postgresql/CHANGELOG.md#small1612-2024-11-06-small)

-   \[bitnami/postgresql] Release 16.1.2 ([#&#8203;30250](bitnami/charts#30250)) ([423c554](bitnami/charts@423c554)), closes [#&#8203;30250](bitnami/charts#30250)

### [`v16.1.1`](https://github.com/bitnami/charts/blob/HEAD/bitnami/postgresql/CHANGELOG.md#small1611-2024-11-04-small)

-   \[bitnami/postgresql] metrics.collectors applies to read replicas ([#&#8203;30133](bitnami/charts#30133)) ([696f113](bitnami/charts@696f113)), closes [#&#8203;30133](bitnami/charts#30133)

### [`v16.1.0`](https://github.com/bitnami/charts/blob/HEAD/bitnami/postgresql/CHANGELOG.md#1610-2024-10-30)

-   \[bitnami/\*] Remove wrong comment about imagePullPolicy ([#&#8203;30107](bitnami/charts#30107)) ([a51f9e4](bitnami/charts@a51f9e4)), closes [#&#8203;30107](bitnami/charts#30107)
-   \[bitnami/postgresql] Added support for `namespaceOverride` ([#&#8203;30113](bitnami/charts#30113)) ([4253372](bitnami/charts@4253372)), closes [#&#8203;30113](bitnami/charts#30113)

### [`v16.0.6`](https://github.com/bitnami/charts/blob/HEAD/bitnami/postgresql/CHANGELOG.md#small1606-2024-10-24-small)

-   \[bitnami/postgresql] Release 16.0.6 ([#&#8203;30069](bitnami/charts#30069)) ([e431b4a](bitnami/charts@e431b4a)), closes [#&#8203;30069](bitnami/charts#30069)

### [`v16.0.5`](https://github.com/bitnami/charts/blob/HEAD/bitnami/postgresql/CHANGELOG.md#small1605-2024-10-22-small)

-   \[bitnami/postgresql] Release 16.0.5 ([#&#8203;30046](bitnami/charts#30046)) ([a825e37](bitnami/charts@a825e37)), closes [#&#8203;30046](bitnami/charts#30046)

### [`v16.0.4`](https://github.com/bitnami/charts/blob/HEAD/bitnami/postgresql/CHANGELOG.md#small1604-2024-10-21-small)

-   \[bitnami/postgresql] Release 16.0.4 ([#&#8203;30013](bitnami/charts#30013)) ([8435f88](bitnami/charts@8435f88)), closes [#&#8203;30013](bitnami/charts#30013)

### [`v16.0.3`](https://github.com/bitnami/charts/blob/HEAD/bitnami/postgresql/CHANGELOG.md#small1603-2024-10-16-small)

-   \[bitnami/postgresql] Release 16.0.3 ([#&#8203;29942](bitnami/charts#29942)) ([7b3f2bb](bitnami/charts@7b3f2bb)), closes [#&#8203;29942](bitnami/charts#29942)

### [`v16.0.2`](https://github.com/bitnami/charts/blob/HEAD/bitnami/postgresql/CHANGELOG.md#small1602-2024-10-16-small)

-   \[bitnami/postgresql] Release 16.0.2 ([#&#8203;29938](bitnami/charts#29938)) ([766c157](bitnami/charts@766c157)), closes [#&#8203;29938](bitnami/charts#29938)
-   Update documentation links to techdocs.broadcom.com ([#&#8203;29931](bitnami/charts#29931)) ([f0d9ad7](bitnami/charts@f0d9ad7)), closes [#&#8203;29931](bitnami/charts#29931)

### [`v16.0.1`](https://github.com/bitnami/charts/blob/HEAD/bitnami/postgresql/CHANGELOG.md#small1601-2024-10-04-small)

-   \[bitnami/postgresql] Release 16.0.1 ([#&#8203;29776](bitnami/charts#29776)) ([9d7fcdc](bitnami/charts@9d7fcdc)), closes [#&#8203;29776](bitnami/charts#29776)

### [`v16.0.0`](https://github.com/bitnami/charts/blob/HEAD/bitnami/postgresql/CHANGELOG.md#1600-2024-10-02)

-   \[bitnami/postgresql] Release 16.0.0 ([#&#8203;29723](bitnami/charts#29723)) ([aeedc0e](bitnami/charts@aeedc0e)), closes [#&#8203;29723](bitnami/charts#29723)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "* * * * 0,6" (UTC), Automerge - "* 0-3 * * *" (UTC).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS40MC4xIiwidXBkYXRlZEluVmVyIjoiMzkuMTU2LjEiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImtpbmQvZGVwZW5kZW5jeSJdfQ==-->

Co-authored-by: pat-s <[email protected]>
Reviewed-on: https://gitea.com/gitea/helm-chart/pulls/736
Reviewed-by: pat-s <[email protected]>
Co-authored-by: Renovate Bot <[email protected]>
Co-committed-by: Renovate Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

postgresql solved verify Execute verification workflow for these changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bitnami/postgresql] metrics.collectors ignored for read replica

4 participants