[bitnami/mastodon] fix extraVolumes if conditional and indentation for init-job.yaml#20901
Merged
CeliaGMqrz merged 4 commits intobitnami:mainfrom Nov 21, 2023
jessebot:fix-init-job-extra-volumes
Merged
[bitnami/mastodon] fix extraVolumes if conditional and indentation for init-job.yaml#20901CeliaGMqrz merged 4 commits intobitnami:mainfrom jessebot:fix-init-job-extra-volumes
extraVolumes if conditional and indentation for init-job.yaml#20901CeliaGMqrz merged 4 commits intobitnami:mainfrom
jessebot:fix-init-job-extra-volumes
Conversation
Signed-off-by: jessebot <[email protected]>
…ob.yaml Signed-off-by: jessebot <[email protected]>
jessebot
commented
Nov 11, 2023
Contributor
|
Hi @jessebot Sorry for my late response. Thanks for your contribution! Could you update the chart version? version: 3.2.4 |
Signed-off-by: JesseBot <[email protected]>
Contributor
Author
no problem at all! sorry for my mine as well :) |
Signed-off-by: JesseBot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
This fixes the
ifconditional forextraVolumesin in the init-job.yaml to check forinitJob.extraVolumesas there is currently noextraVolumesparameter. This also fixes the indentation for extraVolumes, as it was off by a couple of spaces.Benefits
Now you can use extra volumes for the init job, which will fix the error when you try to apply the helm chart templated manifests, because only volume_Mounts_ were templated. For instance in Argo CD, if you have extra volumes and extra volume mounts for the init job, you get:
Possible drawbacks
don't believe there are any, as this is a simple bug fix
Applicable issues
none at this moment, I don't think
Additional information
none that I can think of
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm