Fix use of Result in macro output #462
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KodrAus
reviewed
Oct 2, 2025
KodrAus
reviewed
Oct 2, 2025
KodrAus
reviewed
Oct 2, 2025
Member
KodrAus
left a comment
KodrAus
left a comment
There was a problem hiding this comment.
Thanks for working on this @james7132! I think we just need to update the serde_core version to one that's actually published, but otherwise this looks good to me.
KodrAus
reviewed
Oct 3, 2025
KodrAus
reviewed
Oct 4, 2025
Member
KodrAus
left a comment
KodrAus
left a comment
There was a problem hiding this comment.
Just spotted one more nitpick, then this should be good to go!
Member
|
I had a look at those build failures and fixed this up in #467. If you'd like to scope this PR back to just the |
Contributor
Author
|
Currently on vacation, will do so sometime next week. |
james7132
changed the title
Contributor
Author
|
@KodrAus done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serde recently split out the trait definitions from the top level serde crate. This crate does not rely on the derive macro, so it should be effective to depend on serde_core instead of serde. This doesn't impact the compilation times of bitflags itself, but allows it to parallelize withDone in #467.serde-deriveand potentially other crates likeserde-jsonthat also do not rely on the derive macro, unblocking other crates reliant on bitflags to do so as well.This PR fully qualifies the path of the use of Result in the generated macro code.