Skip to content

Conversation

@KodrAus
Copy link
Member

@KodrAus KodrAus commented Aug 11, 2025

Closes #447

cc @tgross35 does this look right to you? If bitflags is no longer a dependency of the standard library does that mean we can remove the rustc-dep-of-std feature too?

@tgross35
Copy link
Contributor

The minimal change is just dropping the compiler_builtins dep and feature, since those are no longer needed for dependencies of the standard library (the in-tree compiler_builtins gets added instead). The rustc-dep-of-std bit would still be needed though, so that may be worth keeping around if you think there is a chance this winds back up in std's graph.

@KodrAus
Copy link
Member Author

KodrAus commented Aug 15, 2025

Ah I see 👍 Since the library isn't currently a dependency of std I'll remove that feature too, but if it ever finds its way back there we can always re-add it.

@KodrAus KodrAus merged commit f1beb28 into bitflags:main Aug 16, 2025
10 checks passed
@KodrAus KodrAus deleted the fix/rustc-dep-of-std branch August 16, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop the compiler_builtins dependency and feature

2 participants