Skip to content

Conversation

@wysiwys
Copy link
Contributor

@wysiwys wysiwys commented Dec 20, 2024

This PR adds a method to the Flags trait, contains_unknown_bits(&self), to check whether any unknown bits are set (See #425). It also adds tests for this method.

Copy link
Member

@KodrAus KodrAus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wysiwys! This looks great 👍

@KodrAus
Copy link
Member

KodrAus commented Dec 25, 2024

Build failure is unrelated; a few error messages have changed

@KodrAus KodrAus merged commit 541cc66 into bitflags:main Dec 25, 2024
9 of 10 checks passed
@cwfitzgerald
Copy link

Thank you for landing this!

Is there any reason these weren't added as inherent methods too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants