rpc: add period_start to version bits statistics

Sjors · Sjors · commit b2773c7a6eb9 · 2021-07-21T10:15:53.000+02:00
diff --git a/src/rpc/blockchain.cpp b/src/rpc/blockchain.cpp
@@ -1389,6 +1389,7 @@ static void SoftForkDescPushBack(const CBlockIndex* active_chain_tip, UniValue&
         UniValue statsUV(UniValue::VOBJ);
         BIP9Stats statsStruct = g_versionbitscache.Statistics(active_chain_tip, consensusParams, id);
         statsUV.pushKV("period", statsStruct.period);
+        statsUV.pushKV("period_start", active_chain_tip->nHeight + 1 - statsStruct.elapsed);
         statsUV.pushKV("elapsed", statsStruct.elapsed);
         statsUV.pushKV("count", statsStruct.count);
         if (ThresholdState::LOCKED_IN != thresholdState) {
@@ -1449,6 +1450,7 @@ RPCHelpMan getblockchaininfo()
                                     {RPCResult::Type::OBJ, "statistics", "numeric statistics about signalling for a softfork (only for \"started\" and \"locked_in\" status)",
                                     {
                                         {RPCResult::Type::NUM, "period", "the length in blocks of the signalling period"},
+                                        {RPCResult::Type::NUM, "period_start", "height of the first block of this signalling period"},
                                         {RPCResult::Type::NUM, "threshold", "the number of blocks with the version bit set required to activate the feature (only for \"started\" status)"},
                                         {RPCResult::Type::NUM, "elapsed", "the number of blocks elapsed since the beginning of the current period"},
                                         {RPCResult::Type::NUM, "count", "the number of blocks with the version bit set in the current period"},
diff --git a/test/functional/rpc_blockchain.py b/test/functional/rpc_blockchain.py
@@ -147,6 +147,7 @@ def _test_getblockchaininfo(self):
                     'since': 144,
                     'statistics': {
                         'period': 144,
+                        'period_start': 144,
                         'threshold': 108,
                         'elapsed': 57,
                         'count': 57,
