Fix P2PClient parsing unknown messages #2315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benthecarman
force-pushed
the
fix-p2p-parsing-unknown-msgs
branch
from
28abbc3 to
4823b17
Compare
rorp
reviewed
Dec 3, 2020
| loop(newRemainingBytes, message :: accum) | ||
| case Failure(_) => | ||
| // Can't parse message yet, we need to wait for more bytes | ||
| (accum.reverse, remainingBytes) |
Contributor
There was a problem hiding this comment.
Although if we change accum type to Vector we could simply append new messages, and wouldn't need reverse
Collaborator
Author
There was a problem hiding this comment.
Changed to use Vector and removed the reverses
benthecarman
force-pushed
the
fix-p2p-parsing-unknown-msgs
branch
from
4823b17 to
03024f2
Compare
Christewart
approved these changes
Dec 6, 2020
Contributor
|
Tested 03024f2 by syncing a few thousand blocks on testnet, everything worked fine. |
Christewart
pushed a commit
that referenced
this pull request
May 1, 2021
* Fix P2PClient parsing unknown messages * Use Vector, calculate correct checksum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried syncing my node with the latest release candidate of Bitcoin Core and found it wouldn't sync.
The error was that it wasn't able to parse the new P2P messages introduced. This fixes that by checking if it's an unknown type to skip the message.