This repository was archived by the owner on Jun 17, 2022. It is now read-only.
[tests] Fix BOOST_CHECK_THROW macro #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BOOST_CHECK_THROW doesn't correctly fail the test if no exception is throw. Fix that (and add an assert message). Bug and fix found by MarcoFalke.
|
Concept ACK ec849d9. Thx |
laanwj
added a commit
that referenced
this pull request
Dec 19, 2017
ec849d9 [tests] Fix BOOST_CHECK_THROW macro (John Newbery) Pull request description: BOOST_CHECK_THROW doesn't correctly fail the test if no exception is throw. Fix that (and add an assert message). Bug and fix found by MarcoFalke. @MarcoFalke Tree-SHA512: 6920a5091cb432d6914b4f961ab398dfdbd5ae3f46831d164b2d3d65786c450b284ca0c3cd433a5402020d25191b00aaa76f302e3164b62092a75fbb1e8fee83
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BOOST_CHECK_THROW doesn't correctly fail the test if no
exception is throw. Fix that (and add an assert message).
Bug and fix found by MarcoFalke.
@MarcoFalke