Fix support for vector<bool> serialization with libc++ #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vector<bool> serialization supported added in bitcoin-core#86 commit 1c6fb04 was only tested with libstdc++ not libc++ and caused a test compilation failure when compiling on macos, reported by edilmedeiros in bitcoin-core#92 Fix the issue that was causing the build to fail: trying to use using vector's reference type instead of const_reference type when serializing the vector. Fixes bitcoin-core#92
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jan 22, 2024
Fixes bitcoin#29248 The std::result_of type was removed in c++20, but was being referenced in some old, unused code in the library. The issue was fixed in: bitcoin-core/libmultiprocess#91 util: Drop Bind, BindTuple, ComposeFn, GetFn, and ThrowFn helpers This update also includes other recent libmultiprocess changes to improve C++20 support and fix build issues: bitcoin-core/libmultiprocess#89 pkgconfig: Drop -std=c++17 compile flag bitcoin-core/libmultiprocess#90 pkgconfig: Use @CMAKE_INSTALL_LIBDIR@ variable bitcoin-core/libmultiprocess#93 Fix support for vector<bool> serialization with libc++
|
I confirm that the changes in 8da797c now make the tests compile and pass in my box. I compiled and checked them by getting dependencies from both Brew and Macports. |
fanquake
added a commit
to bitcoin/bitcoin
that referenced
this pull request
Jan 23, 2024
…cos build error b8105b3 depends: Update libmultiprocess library to fix C++20 macos build error (Ryan Ofsky) Pull request description: Fixes #29248 The std::result_of type was removed in c++20, but was being referenced in some old, unused code in the library. The issue was fixed in: - bitcoin-core/libmultiprocess#91 This update also includes other recent libmultiprocess changes to improve C++20 support and fix build issues: - bitcoin-core/libmultiprocess#89 - bitcoin-core/libmultiprocess#90 - bitcoin-core/libmultiprocess#93 ACKs for top commit: fanquake: ACK b8105b3. Tree-SHA512: 2ca64b5fc27be752baba38df4b4faf62152e18c70ead6e0e063f1cb0c25dd5d924dec7ebfd7f8bbd651ae50eb35e8d8b591a9847c36f22558b5f5effccf56536
janus
pushed a commit
to BitgesellOfficial/bitgesell
that referenced
this pull request
Apr 6, 2024
Fixes #29248 The std::result_of type was removed in c++20, but was being referenced in some old, unused code in the library. The issue was fixed in: bitcoin-core/libmultiprocess#91 util: Drop Bind, BindTuple, ComposeFn, GetFn, and ThrowFn helpers This update also includes other recent libmultiprocess changes to improve C++20 support and fix build issues: bitcoin-core/libmultiprocess#89 pkgconfig: Drop -std=c++17 compile flag bitcoin-core/libmultiprocess#90 pkgconfig: Use @CMAKE_INSTALL_LIBDIR@ variable bitcoin-core/libmultiprocess#93 Fix support for vector<bool> serialization with libc++
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Oct 1, 2024
…++20 macos build error b8105b3 depends: Update libmultiprocess library to fix C++20 macos build error (Ryan Ofsky) Pull request description: Fixes bitcoin#29248 The std::result_of type was removed in c++20, but was being referenced in some old, unused code in the library. The issue was fixed in: - bitcoin-core/libmultiprocess#91 This update also includes other recent libmultiprocess changes to improve C++20 support and fix build issues: - bitcoin-core/libmultiprocess#89 - bitcoin-core/libmultiprocess#90 - bitcoin-core/libmultiprocess#93 ACKs for top commit: fanquake: ACK b8105b3. Tree-SHA512: 2ca64b5fc27be752baba38df4b4faf62152e18c70ead6e0e063f1cb0c25dd5d924dec7ebfd7f8bbd651ae50eb35e8d8b591a9847c36f22558b5f5effccf56536
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
vector<bool>serialization support added in #86 commit 1c6fb04 was only tested with libstdc++ not libc++ and caused a test compilation failure when compiling on macos, reported by edilmedeiros in #92Fix the issue that was causing the build to fail: trying to use using vector's reference type instead of const_reference type when serializing the vector.
Fixes #92