Make {v}snprintf definition dependent on _MSC_VER #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
utACK |
Member
|
Needs rebase after #14 |
VS2015 already has a definition for snprintf. This results into compilation error: D:\work\leveldb-1.20\port/port_win.h(35): note: see previous definition of 'snprintf' C:\Program Files (x86)\Windows Kits\10\include\10.0.10240.0\ucrt\stdio.h(1927): fatal error C1189: #error: Macro definition of snprintf conflicts with Standard Library function declaration This patch makes the definition of snprintf and vsnprintf conditional, based on the value of the macro _MSC_VER
Author
|
@laanwj I have rebased my changes. |
Member
|
Thank you. utACK a3ae607 |
laanwj
added a commit
that referenced
this pull request
Mar 21, 2019
a3ae607 Make {v}snprintf definition dependent on _MSC_VER (Nehal J Wani) Pull request description: `VS2015` already has a definition for `snprintf`. This results into compilation error: ``` D:\work\leveldb-1.20\port/port_win.h(35): note: see previous definition of 'snprintf' C:\Program Files (x86)\Windows Kits\10\include\10.0.10240.0\ucrt\stdio.h(1927): fatal error C1189: #error: Macro definition of snprintf conflicts with Standard Library function declaration ``` This patch makes the definition of `snprintf` and `vsnprintf` conditional, based on the value of the macro `_MSC_VER` Tree-SHA512: 4bae38f584057cac1c2aebe7958852be391ba23ea7d9062bab5cc90f8951bf63ed02aaa195e706a3db2c4f9876c495081642f19d7523659c379cdbbc948eba6a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VS2015already has a definition forsnprintf. This results into compilation error:This patch makes the definition of
snprintfandvsnprintfconditional,based on the value of the macro
_MSC_VER