Remove proxy checkboxes from options #421
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarolrod
reviewed
Sep 14, 2021
Contributor
jarolrod
left a comment
jarolrod
left a comment
There was a problem hiding this comment.
NACK
The use cases for these check boxes is specifying where to use a proxy and then setting a different proxy for usage with tor.
You can't go and start removing code because "you don't use it"; especially when you don't provide any justification and don't fully understand what it's doing.
Author
Can you share docs or steps how is this option being used or helpful? |
Author
|
@hebasto Thanks for answering. Will close this PR as I am not sure about removal although I think some changes or discussion is required because:
|
ghost
closed this
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Never used these checkboxes. No response on IRC or SE so I am assuming its not useful: https://bitcoin.stackexchange.com/questions/109636/understanding-network-options-in-bitcoin-core-gui
Will get some extra space and need to add checkboxes for
onlynetnext: #413