Elide long strings in their middle in the Peers tab #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Concept ACK, this looks like a real and practical improvement. |
promag
reviewed
Apr 10, 2021
Member
Author
|
Because of wordWrap=true by default.
On Sat, 10 Apr 2021 at 22:01 João Barbosa ***@***.***> wrote:
***@***.**** commented on this pull request.
Concept ACK
Why does it show only ellipsis on the 1st sreenshot?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#276 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AH3PXPSYOICYOCDSTHGZVMDTICOARANCNFSM42WM3Z6A>
.
--
…--
Hennadii Stepanov
|
Contributor
|
🎉 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 19, 2021
… Peers tab 4e06133 qt: Elide long strings in their middle in the Peers tab (Hennadii Stepanov) Pull request description: The eliding of long addresses (Onion v3 etc) in the Peers tab in their middle was [discussed](bitcoin-core/gui#262 (comment)) in #262. On master (f0fa324):  With this PR:  This PR suggests the minimal diff to achieve the goal. OTOH, this change in behavior is common for all columns in the Peers table, but it seems harmless. ACKs for top commit: jarolrod: tACK 4e06133 promag: Code review ACK 4e06133. Tree-SHA512: 1d5a62afb1152029e69fccea2ae53dcb262a91724a5c03dfc4de8c409b280814d0c211c2f9a71f1a6e927f4ed571ba4ac311de9de8ebb797eaf1051674241bdb
barton2526
added a commit
to barton2526/Gridcoin-Research
that referenced
this pull request
Jul 17, 2021
barton2526
added a commit
to barton2526/Gridcoin-Research
that referenced
this pull request
Jul 17, 2021
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Oct 21, 2021
… Peers tab 4e06133 qt: Elide long strings in their middle in the Peers tab (Hennadii Stepanov) Pull request description: The eliding of long addresses (Onion v3 etc) in the Peers tab in their middle was [discussed](bitcoin-core/gui#262 (comment)) in dashpay#262. On master (f0fa324):  With this PR:  This PR suggests the minimal diff to achieve the goal. OTOH, this change in behavior is common for all columns in the Peers table, but it seems harmless. ACKs for top commit: jarolrod: tACK 4e06133 promag: Code review ACK 4e06133. Tree-SHA512: 1d5a62afb1152029e69fccea2ae53dcb262a91724a5c03dfc4de8c409b280814d0c211c2f9a71f1a6e927f4ed571ba4ac311de9de8ebb797eaf1051674241bdb
pravblockc
pushed a commit
to pravblockc/dash
that referenced
this pull request
Nov 18, 2021
… Peers tab 4e06133 qt: Elide long strings in their middle in the Peers tab (Hennadii Stepanov) Pull request description: The eliding of long addresses (Onion v3 etc) in the Peers tab in their middle was [discussed](bitcoin-core/gui#262 (comment)) in dashpay#262. On master (f0fa324):  With this PR:  This PR suggests the minimal diff to achieve the goal. OTOH, this change in behavior is common for all columns in the Peers table, but it seems harmless. ACKs for top commit: jarolrod: tACK 4e06133 promag: Code review ACK 4e06133. Tree-SHA512: 1d5a62afb1152029e69fccea2ae53dcb262a91724a5c03dfc4de8c409b280814d0c211c2f9a71f1a6e927f4ed571ba4ac311de9de8ebb797eaf1051674241bdb
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
May 9, 2022
… Peers tab 4e06133 qt: Elide long strings in their middle in the Peers tab (Hennadii Stepanov) Pull request description: The eliding of long addresses (Onion v3 etc) in the Peers tab in their middle was [discussed](bitcoin-core/gui#262 (comment)) in dashpay#262. On master (f0fa324):  With this PR:  This PR suggests the minimal diff to achieve the goal. OTOH, this change in behavior is common for all columns in the Peers table, but it seems harmless. ACKs for top commit: jarolrod: tACK 4e06133 promag: Code review ACK 4e06133. Tree-SHA512: 1d5a62afb1152029e69fccea2ae53dcb262a91724a5c03dfc4de8c409b280814d0c211c2f9a71f1a6e927f4ed571ba4ac311de9de8ebb797eaf1051674241bdb
gwillen
pushed a commit
to ElementsProject/elements
that referenced
this pull request
Jun 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The eliding of long addresses (Onion v3 etc) in the Peers tab in their middle was discussed in #262.
On master (f0fa324):
With this PR:
This PR suggests the minimal diff to achieve the goal. OTOH, this change in behavior is common for all columns in the Peers table, but it seems harmless.