Fix checkbox layout in Create Wallet dialog #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
cc @0xB10C |
Contributor
|
This seems to fix it! Thanks. rc3: pr155: |
Contributor
|
review ACK e71b656 didn't test |
Contributor
|
Shouldn't this be a flexible (stretch layout instead of fixed pixles? |
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Dec 18, 2020
Github-Pull: bitcoin-core/gui#155 Rebased-From: e71b656
Contributor
|
This can be reworked for 0.22, but I think for rc4 we should aim for a minimal fix |
Member
Author
The goal of this PR was the minimal fix as @MarcoFalke said. Besides, the issue has spotted on i3 window manager, and the real problem could be much deeper. |
Contributor
|
post merge utACK the fix. I missed the rc4 issue or 0.21 tag... |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Dec 18, 2020
e71b656 qt: Align layout of checkboxes (Hennadii Stepanov) Pull request description: From bitcoin#20555 (comment): > 0.21.0rc3 compiled from source, Ubuntu 20.04 + i3: tested mainnet, testnet, and signet. created a descriptor wallet in qt, tested torv3 with addnode, and checked if anchors.dat is created on shutdown and removed on startup. > > I've noticed the "Advanced options" label being cut-off in the wallet creation dialog. This PR should fix this issue. ACKs for top commit: MarcoFalke: review ACK e71b656 Tree-SHA512: dcc997a440a96fc936296323afaf9f4040ac06cf5ad32724a88c2e2e16c726c35b1b2bacbb3e081839d8a69b5a6086b2570d6b2e98976f29b5427db2d434eee9
ComputerCraftr
pushed a commit
to ElectraProtocol/XEP-Core
that referenced
this pull request
Jan 3, 2021
Github-Pull: bitcoin-core/gui#155 Rebased-From: e71b656f317f38ef0ba0874736f116dae39efc67
ComputerCraftr
pushed a commit
to ComputerCraftr/XEP-Core
that referenced
this pull request
Jan 5, 2021
Github-Pull: bitcoin-core/gui#155 Rebased-From: e71b656f317f38ef0ba0874736f116dae39efc67
apoelstra
pushed a commit
to apoelstra/elements
that referenced
this pull request
Sep 1, 2021
Github-Pull: bitcoin-core/gui#155 Rebased-From: e71b656 (cherry picked from commit ef7a155)
apoelstra
pushed a commit
to apoelstra/elements
that referenced
this pull request
Sep 18, 2021
Github-Pull: bitcoin-core/gui#155 Rebased-From: e71b656 (cherry picked from commit ef7a155)
apoelstra
pushed a commit
to apoelstra/elements
that referenced
this pull request
Sep 22, 2021
Github-Pull: bitcoin-core/gui#155 Rebased-From: e71b656 (cherry picked from commit ef7a155)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From bitcoin/bitcoin#20555 (comment):
This PR should fix this issue.