gui: crash fix, do not consume numBlocksChanged() events during shutdown

furszy · furszy · commit c6f4b0d79606 · 2025-04-10T11:17:16.000-04:00
Attempting to update views during shutdown can crash the app due to
accessing backend models that may no longer exist.

The shutdown procedure begins by unsetting clientModel from all views.
Therefore, it’s safe to ignore events when clientModel is nullptr.
diff --git a/src/qt/sendcoinsdialog.cpp b/src/qt/sendcoinsdialog.cpp
@@ -855,7 +855,7 @@ void SendCoinsDialog::updateCoinControlState()
 }
 
 void SendCoinsDialog::updateNumberOfBlocks(int count, const QDateTime& blockDate, double nVerificationProgress, SyncType synctype, SynchronizationState sync_state) {
-    if (sync_state == SynchronizationState::POST_INIT) {
+    if (sync_state == SynchronizationState::POST_INIT && clientModel) {
         updateSmartFeeLabel();
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -855,7 +855,7 @@ void SendCoinsDialog::updateCoinControlState()`
`855`	`855`	`}`
`856`	`856`
`857`	`857`	`void SendCoinsDialog::updateNumberOfBlocks(int count, const QDateTime& blockDate, double nVerificationProgress, SyncType synctype, SynchronizationState sync_state) {`
`858`		`- if (sync_state == SynchronizationState::POST_INIT) {`
	`858`	`+ if (sync_state == SynchronizationState::POST_INIT && clientModel) {`
`859`	`859`	`updateSmartFeeLabel();`
`860`	`860`	`}`
`861`	`861`	`}`