Persist "mask values" in gui

jadijadi · jadijadi · commit 9fde0bae916f · 2022-09-22T11:33:50.000+03:30
fixes #652
diff --git a/src/qt/bitcoingui.cpp b/src/qt/bitcoingui.cpp
@@ -246,6 +246,8 @@ BitcoinGUI::~BitcoinGUI()
 
 void BitcoinGUI::createActions()
 {
+    QSettings settings;
+
     QActionGroup *tabGroup = new QActionGroup(this);
     connect(modalOverlay, &ModalOverlay::triggered, tabGroup, &QActionGroup::setEnabled);
 
@@ -359,6 +361,7 @@ void BitcoinGUI::createActions()
     m_mask_values_action->setShortcut(QKeySequence(Qt::CTRL | Qt::SHIFT | Qt::Key_M));
     m_mask_values_action->setStatusTip(tr("Mask the values in the Overview tab"));
     m_mask_values_action->setCheckable(true);
+    m_mask_values_action->setChecked(settings.value("privacy").toBool());
 
     connect(quitAction, &QAction::triggered, this, &BitcoinGUI::quitRequested);
     connect(aboutAction, &QAction::triggered, this, &BitcoinGUI::aboutClicked);
diff --git a/src/qt/optionsmodel.cpp b/src/qt/optionsmodel.cpp
@@ -54,6 +54,7 @@ static const char* SettingName(OptionsModel::OptionID option)
     case OptionsModel::ProxyPortTor: return "onion";
     case OptionsModel::ProxyUseTor: return "onion";
     case OptionsModel::Language: return "lang";
+    case OptionsModel::Privacy: return "privacy";
     default: throw std::logic_error(strprintf("GUI option %i has no corresponding node setting.", option));
     }
 }
@@ -189,6 +190,10 @@ bool OptionsModel::Init(bilingual_str& error)
     }
     m_enable_psbt_controls = settings.value("enable_psbt_controls", false).toBool();
 
+    if (!settings.contains("privacy")) {
+        settings.setValue("privacy", false);
+    }
+
     // These are shared with the core or have a command-line parameter
     // and we want command-line parameters to overwrite the GUI settings.
     for (OptionID option : {DatabaseCache, ThreadsScriptVerif, SpendZeroConfChange, ExternalSignerPath, MapPortUPnP,
diff --git a/src/qt/optionsmodel.h b/src/qt/optionsmodel.h
@@ -51,6 +51,7 @@ class OptionsModel : public QAbstractListModel
         MapPortUPnP,            // bool
         MapPortNatpmp,          // bool
         MinimizeOnClose,        // bool
+        Privacy,                // bool
         ProxyUse,               // bool
         ProxyIP,                // QString
         ProxyPort,              // int
diff --git a/src/qt/overviewpage.cpp b/src/qt/overviewpage.cpp
@@ -16,6 +16,8 @@
 #include <qt/transactiontablemodel.h>
 #include <qt/walletmodel.h>
 
+#include <QSettings>
+
 #include <QAbstractItemDelegate>
 #include <QApplication>
 #include <QDateTime>
@@ -176,6 +178,9 @@ void OverviewPage::handleTransactionClicked(const QModelIndex &index)
 
 void OverviewPage::setPrivacy(bool privacy)
 {
+    QSettings settings;
+    settings.setValue("privacy", privacy);
+
     m_privacy = privacy;
     if (m_balances.balance != -1) {
         setBalance(m_balances);

Original file line number	Diff line number	Diff line change
`@@ -54,6 +54,7 @@ static const char* SettingName(OptionsModel::OptionID option)`
`54`	`54`	`case OptionsModel::ProxyPortTor: return "onion";`
`55`	`55`	`case OptionsModel::ProxyUseTor: return "onion";`
`56`	`56`	`case OptionsModel::Language: return "lang";`
	`57`	`+ case OptionsModel::Privacy: return "privacy";`
`57`	`58`	`default: throw std::logic_error(strprintf("GUI option %i has no corresponding node setting.", option));`
`58`	`59`	`}`
`59`	`60`	`}`
`@@ -189,6 +190,10 @@ bool OptionsModel::Init(bilingual_str& error)`
`189`	`190`	`}`
`190`	`191`	`m_enable_psbt_controls = settings.value("enable_psbt_controls", false).toBool();`
`191`	`192`
	`193`	`+ if (!settings.contains("privacy")) {`
	`194`	`+ settings.setValue("privacy", false);`
	`195`	`+ }`
	`196`	`+`
`192`	`197`	`// These are shared with the core or have a command-line parameter`
`193`	`198`	`// and we want command-line parameters to overwrite the GUI settings.`
`194`	`199`	`for (OptionID option : {DatabaseCache, ThreadsScriptVerif, SpendZeroConfChange, ExternalSignerPath, MapPortUPnP,`