qt: Avoid spurious updateStatus() calls during shutdown

hebasto · ryanofsky · hebasto · commit 9735b0750bc1 · 2020-06-19T18:54:22.000+03:00
Co-authored-by: Russell Yanofsky &lt;russ@yanofsky.org&gt;
diff --git a/src/qt/transactiontablemodel.cpp b/src/qt/transactiontablemodel.cpp
@@ -192,7 +192,7 @@ class TransactionTablePriv
             interfaces::WalletTxStatus wtx;
             int numBlocks;
             int64_t block_time;
-            if (rec->statusUpdateNeeded(cur_block_hash) && wallet.tryGetTxStatus(rec->hash, wtx, numBlocks, block_time)) {
+            if (!cur_block_hash.IsNull() && rec->statusUpdateNeeded(cur_block_hash) && wallet.tryGetTxStatus(rec->hash, wtx, numBlocks, block_time)) {
                 rec->updateStatus(wtx, cur_block_hash, numBlocks, block_time);
             }
             return rec;

Original file line number	Diff line number	Diff line change
`@@ -192,7 +192,7 @@ class TransactionTablePriv`
`192`	`192`	`interfaces::WalletTxStatus wtx;`
`193`	`193`	`int numBlocks;`
`194`	`194`	`int64_t block_time;`
`195`		`- if (rec->statusUpdateNeeded(cur_block_hash) && wallet.tryGetTxStatus(rec->hash, wtx, numBlocks, block_time)) {`
	`195`	`+ if (!cur_block_hash.IsNull() && rec->statusUpdateNeeded(cur_block_hash) && wallet.tryGetTxStatus(rec->hash, wtx, numBlocks, block_time)) {`
`196`	`196`	`rec->updateStatus(wtx, cur_block_hash, numBlocks, block_time);`
`197`	`197`	`}`
`198`	`198`	`return rec;`