qt: Rework RPCConsole::clearSelectedNode function

hebasto · hebasto · commit 6f1ccc74b260 · 2020-12-23T21:59:45.000+02:00
Only successfully disconnected peers are deselected from the selection.
diff --git a/src/qt/rpcconsole.cpp b/src/qt/rpcconsole.cpp
@@ -647,7 +647,7 @@ void RPCConsole::setClientModel(ClientModel *model, int bestblock_height, int64_
         connect(unbanAction, &QAction::triggered, this, &RPCConsole::unbanSelectedNode);
 
         // ban table signal handling - clear peer details when clicking a peer in the ban table
-        connect(ui->banlistWidget, &QTableView::clicked, this, &RPCConsole::clearSelectedNode);
+        connect(ui->banlistWidget, &QTableView::clicked, ui->peerWidget->selectionModel(), &QItemSelectionModel::clearSelection);
         // ban table signal handling - ensure ban table is shown or hidden (if empty)
         connect(model->getBanTableModel(), &BanTableModel::layoutChanged, this, &RPCConsole::showOrHideBanTableIfRequired);
         showOrHideBanTableIfRequired();
@@ -1125,8 +1125,9 @@ void RPCConsole::disconnectSelectedNode()
         // Get currently selected peer address
         NodeId id = nodes.at(i).data().toLongLong();
         // Find the node, disconnect it and clear the selected node
-        if(m_node.disconnectById(id))
-            clearSelectedNode();
+        if (m_node.disconnectById(id)) {
+            clearSelectedNode(nodes.at(i));
+        }
     }
 }
 
@@ -1140,10 +1141,11 @@ void RPCConsole::banSelectedNode(int bantime)
         const CNodeCombinedStats* stats = clientModel->getPeerTableModel()->getNodeStats(peer.row());
         if (stats) {
             m_node.ban(stats->nodeStats.addr, bantime);
-            m_node.disconnectByAddress(stats->nodeStats.addr);
+            if (m_node.disconnectByAddress(stats->nodeStats.addr)) {
+                clearSelectedNode(peer);
+            }
         }
     }
-    clearSelectedNode();
     clientModel->getBanTableModel()->refresh();
 }
 
@@ -1168,11 +1170,10 @@ void RPCConsole::unbanSelectedNode()
     }
 }
 
-void RPCConsole::clearSelectedNode()
+void RPCConsole::clearSelectedNode(const QModelIndex& peer)
 {
-    ui->peerWidget->selectionModel()->clearSelection();
-    cachedNodeids.clear();
-    updateDetailWidget();
+    auto selection = ui->peerWidget->selectionModel();
+    selection->select(peer, QItemSelectionModel::Deselect | QItemSelectionModel::Rows);
 }
 
 void RPCConsole::showOrHideBanTableIfRequired()
diff --git a/src/qt/rpcconsole.h b/src/qt/rpcconsole.h
@@ -94,7 +94,7 @@ private Q_SLOTS:
     /** Hides ban table if no bans are present */
     void showOrHideBanTableIfRequired();
     /** clear the selected node */
-    void clearSelectedNode();
+    void clearSelectedNode(const QModelIndex& peer);
     /** show detailed information on ui about selected node */
     void updateDetailWidget();
 

Original file line number	Diff line number	Diff line change
`@@ -647,7 +647,7 @@ void RPCConsole::setClientModel(ClientModel *model, int bestblock_height, int64_`
`647`	`647`	`connect(unbanAction, &QAction::triggered, this, &RPCConsole::unbanSelectedNode);`
`648`	`648`
`649`	`649`	`// ban table signal handling - clear peer details when clicking a peer in the ban table`
`650`		`- connect(ui->banlistWidget, &QTableView::clicked, this, &RPCConsole::clearSelectedNode);`
	`650`	`+ connect(ui->banlistWidget, &QTableView::clicked, ui->peerWidget->selectionModel(), &QItemSelectionModel::clearSelection);`
`651`	`651`	`// ban table signal handling - ensure ban table is shown or hidden (if empty)`
`652`	`652`	`connect(model->getBanTableModel(), &BanTableModel::layoutChanged, this, &RPCConsole::showOrHideBanTableIfRequired);`
`653`	`653`	`showOrHideBanTableIfRequired();`
`@@ -1125,8 +1125,9 @@ void RPCConsole::disconnectSelectedNode()`
`1125`	`1125`	`// Get currently selected peer address`
`1126`	`1126`	`NodeId id = nodes.at(i).data().toLongLong();`
`1127`	`1127`	`// Find the node, disconnect it and clear the selected node`
`1128`		`- if(m_node.disconnectById(id))`
`1129`		`- clearSelectedNode();`
	`1128`	`+ if (m_node.disconnectById(id)) {`
	`1129`	`+ clearSelectedNode(nodes.at(i));`
	`1130`	`+ }`
`1130`	`1131`	`}`
`1131`	`1132`	`}`
`1132`	`1133`
`@@ -1140,10 +1141,11 @@ void RPCConsole::banSelectedNode(int bantime)`
`1140`	`1141`	`const CNodeCombinedStats* stats = clientModel->getPeerTableModel()->getNodeStats(peer.row());`
`1141`	`1142`	`if (stats) {`
`1142`	`1143`	`m_node.ban(stats->nodeStats.addr, bantime);`
`1143`		`- m_node.disconnectByAddress(stats->nodeStats.addr);`
	`1144`	`+ if (m_node.disconnectByAddress(stats->nodeStats.addr)) {`
	`1145`	`+ clearSelectedNode(peer);`
	`1146`	`+ }`
`1144`	`1147`	`}`
`1145`	`1148`	`}`
`1146`		`- clearSelectedNode();`
`1147`	`1149`	`clientModel->getBanTableModel()->refresh();`
`1148`	`1150`	`}`
`1149`	`1151`
`@@ -1168,11 +1170,10 @@ void RPCConsole::unbanSelectedNode()`
`1168`	`1170`	`}`
`1169`	`1171`	`}`
`1170`	`1172`
`1171`		`-void RPCConsole::clearSelectedNode()`
	`1173`	`+void RPCConsole::clearSelectedNode(const QModelIndex& peer)`
`1172`	`1174`	`{`
`1173`		`- ui->peerWidget->selectionModel()->clearSelection();`
`1174`		`- cachedNodeids.clear();`
`1175`		`- updateDetailWidget();`
	`1175`	`+ auto selection = ui->peerWidget->selectionModel();`
	`1176`	`+ selection->select(peer, QItemSelectionModel::Deselect \| QItemSelectionModel::Rows);`
`1176`	`1177`	`}`
`1177`	`1178`
`1178`	`1179`	`void RPCConsole::showOrHideBanTableIfRequired()`