Make IsHex use string_view

sipa · MacroFake · commit 40062997f223 · 2022-04-27T14:12:55.000+02:00
diff --git a/src/util/strencodings.cpp b/src/util/strencodings.cpp
@@ -58,12 +58,10 @@ signed char HexDigit(char c)
     return p_util_hexdigit[(unsigned char)c];
 }
 
-bool IsHex(const std::string& str)
+bool IsHex(std::string_view str)
 {
-    for(std::string::const_iterator it(str.begin()); it != str.end(); ++it)
-    {
-        if (HexDigit(*it) < 0)
-            return false;
+    for (char c : str) {
+        if (HexDigit(c) < 0) return false;
     }
     return (str.size() > 0) && (str.size()%2 == 0);
 }
diff --git a/src/util/strencodings.h b/src/util/strencodings.h
@@ -59,7 +59,7 @@ std::vector<unsigned char> ParseHex(std::string_view str);
 signed char HexDigit(char c);
 /* Returns true if each character in str is a hex character, and has an even
  * number of hex digits.*/
-bool IsHex(const std::string& str);
+bool IsHex(std::string_view str);
 /**
 * Return true if the string is a hex number, optionally prefixed with "0x"
 */

Original file line number	Diff line number	Diff line change
`@@ -58,12 +58,10 @@ signed char HexDigit(char c)`
`58`	`58`	`return p_util_hexdigit[(unsigned char)c];`
`59`	`59`	`}`
`60`	`60`
`61`		`-bool IsHex(const std::string& str)`
	`61`	`+bool IsHex(std::string_view str)`
`62`	`62`	`{`
`63`		`- for(std::string::const_iterator it(str.begin()); it != str.end(); ++it)`
`64`		`- {`
`65`		`- if (HexDigit(*it) < 0)`
`66`		`- return false;`
	`63`	`+ for (char c : str) {`
	`64`	`+ if (HexDigit(c) < 0) return false;`
`67`	`65`	`}`
`68`	`66`	`return (str.size() > 0) && (str.size()%2 == 0);`
`69`	`67`	`}`