github-merge: Handle deleted users gracefully #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle deleted github users gracefully when retrieving ACKs by replacing their name with `[deleted]` in the sanitization function. Tested with bitcoin/bitcoin#15423.
Contributor
|
cr ACK 8b7b630 |
jonatack
approved these changes
Mar 22, 2022
Member
There was a problem hiding this comment.
posthumous review ACK 8b7b630
essential change is adding these three lines, and usual rec['user'] value for the login is of format "login": "octocat" so this appears correct
+ if rec['user'] is None: # User deleted account
+ rec['user'] = {'login': '[deleted]'}
+ else:
This comment was marked as off-topic.
This comment was marked as off-topic.
hacker-smith-ts570pol
added a commit
to hacker-smith-ts570pol/bitcoin-maintainer-tools
that referenced
this pull request
Sep 27, 2025
… deleted users gracefully 8b7b630ea902482ac0cd081abdb1af24f03712cd github-merge: Handle deleted users gracefully (laanwj) Pull request description: Handle deleted github users gracefully when retrieving ACKs by replacing their name with `[deleted]` in the sanitization function. Tested with bitcoin/bitcoin#15423. ACKs for top commit: MarcoFalke: cr ACK 8b7b630ea902482ac0cd081abdb1af24f03712cd Tree-SHA512: 21aa715e4d3196bcde6a8523892afd415c8aae4a440e9ea413a5459ce8c0c978747289a3300e4ff28647cb6af8aded59fd749a06d48b5c2b09896e3eee48d6c1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle deleted github users gracefully when retrieving ACKs by replacing their name with
[deleted]in the sanitization function.Tested with bitcoin/bitcoin#15423.