Add getdescriptors command #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sjors
force-pushed
the
2019/03/getdescriptors
branch
from
7bd94e4 to
0d5eca2
Compare
Sjors
force-pushed
the
2019/03/getdescriptors
branch
from
0d5eca2 to
a83f48e
Compare
Sjors
force-pushed
the
2019/03/getdescriptors
branch
from
a83f48e to
fd4be8f
Compare
Sjors
force-pushed
the
2019/03/getdescriptors
branch
2 times, most recently
from
841f703 to
2922fb9
Compare
Member
Author
|
Rebased and added an xpub cache so we don't fetch the same xpub twice from a device for internal and change descriptors. |
Closed
Sjors
force-pushed
the
2019/03/getdescriptors
branch
from
2922fb9 to
5574645
Compare
Merged
Member
Author
|
Rebased after #135. Works quite well in combination with experimental descriptor native wallet box, see bitcoin/bitcoin#14912 (comment) Paging @achow101 & @instagibbs |
Sjors
force-pushed
the
2019/03/getdescriptors
branch
3 times, most recently
from
df02355 to
99218bd
Compare
Sjors
force-pushed
the
2019/03/getdescriptors
branch
from
99218bd to
b0c6cd7
Compare
Member
|
Tested ACK b0c6cd7 |
achow101
added a commit
that referenced
this pull request
Sep 6, 2019
b0c6cd7 Cache xpubs (Sjors Provoost) 70fad02 Add getdescriptors command (Sjors Provoost) a68b585 Extract getdescriptor from getkeypool (Sjors Provoost) Pull request description: Returns all relevant descriptors for a given account, e.g.: ```sh ./hwi.py --fingerprint 00000000 getdescriptors --account 0 ``` ```json { "receive": [ "pkh([00000000/44h/0h/0h]xpub6C.../0/*)#fn95jwmg", "sh(wpkh([00000000/49h/0h/0h]xpub6B..../0/*))#j4r9hntt", "wpkh([00000000/84h/0h/0h]xpub6C.../0/*)#qw72dxa9" ], "internal": [ "pkh([00000000/44h/0h/0h]xpub6C.../1/*)#c8q40mts", "sh(wpkh([00000000/49h/0h/0h]xpub6B..../1/*))#85dn0v75", "wpkh([00000000/84h/0h/0h]xpub6C..../1/*)#36mtsnda" ] } ``` ACKs for top commit: achow101: Tested ACK b0c6cd7 Tree-SHA512: 68569fa37aee9dd8aa67d547c564e2b455ef3fa50e1f3622f5644942878b815de2c841b29a9b4f152f859fb4780e59ec00415b9e29ff87e2e27ab00526d26c7a
Collaborator
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returns all relevant descriptors for a given account, e.g.:
{ "receive": [ "pkh([00000000/44h/0h/0h]xpub6C.../0/*)#fn95jwmg", "sh(wpkh([00000000/49h/0h/0h]xpub6B..../0/*))#j4r9hntt", "wpkh([00000000/84h/0h/0h]xpub6C.../0/*)#qw72dxa9" ], "internal": [ "pkh([00000000/44h/0h/0h]xpub6C.../1/*)#c8q40mts", "sh(wpkh([00000000/49h/0h/0h]xpub6B..../1/*))#85dn0v75", "wpkh([00000000/84h/0h/0h]xpub6C..../1/*)#36mtsnda" ] }