Create internal and external keypools by default #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
Member
|
Concept ACK |
Member
|
Concept ACK, but do fix the tests :-) Consider rebasing on the first commit of #137, which extracts the descriptor from the |
Closed
Member
|
Fix tests please? I would like to see this merged. |
Collaborator
Author
|
rebased, I have to first make sure ledger tests are passing for master then I'll fix tests |
Collaborator
Author
|
Looks like I got it working properly. @achow101 review ready |
Member
|
ACK b1b7212 |
achow101
added a commit
that referenced
this pull request
Jun 17, 2019
b1b7212 Create internal and external keypools by default (Gregory Sanders) Pull request description: Returns both internal an external chains when `--path` and `--internal` are not given as arguments. ACKs for commit b1b721: achow101: ACK b1b7212 Tree-SHA512: efd45b75a2def8ebb75afef2beb31806b13a26a3ca67a3b64e6e781fc64087e4cc89f4a763a1ccd685bbc8edb7bf22c95dc1b7cc59b2055a8c74f849a4978325
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returns both internal an external chains when
--pathand--internalare not given as arguments.